test(editor): add fixture based markdown round trip tests

.prettierignore

@@ -9,3 +9,6 @@ pnpm-lock.yaml
 
 **/translations.json
 /CHANGELOG.md
+
+# markdown round trip fixtures, formatting is part of the test
+packages/web-pkg/tests/unit/editor/strategies/fixtures/

packages/web-pkg/src/editor/composables/strategies/markdown.ts

@@ -36,12 +36,13 @@ export const useStrategyMarkdown = (editorState: TextEditorState): ContentTypeSt
   // process wide singleton which grows with every editor opened and keeps each
   // manager it ever saw alive. Holding our own instance bounds both to the
   // lifetime of this strategy.
+  const instance = new Marked()
+  registerFrontmatterTokenizer(instance)
+  registerMarkdownListTokenizer(instance)
   // Cast because tiptap types the option as the default export, which carries a
   // `getDefaults` helper a plain instance lacks. The manager never calls it: it
   // only touches `use`, `setOptions`, `Lexer`, `lexer` and `defaults`.
-  const marked = new Marked() as unknown as typeof markedDefault
-  registerFrontmatterTokenizer(marked)
-  registerMarkdownListTokenizer(marked)
+  const marked = instance as unknown as typeof markedDefault
 
   const editorContentType = () => {
     return 'markdown'

packages/web-pkg/src/editor/extensions/frontmatter.ts

@@ -1,6 +1,6 @@
 import { commands as coreCommands, Node, mergeAttributes } from '@tiptap/core'
 import type { CommandProps, JSONContent, MarkdownToken } from '@tiptap/core'
-import type { marked } from 'marked'
+import type { Marked } from 'marked'
 import { TextSelection } from '@tiptap/pm/state'
 import { VueNodeViewRenderer } from '@tiptap/vue-3'
 import FrontmatterComponent from '../components/FrontmatterComponent.vue'
@@ -45,7 +45,7 @@ const frontmatterPattern = /^---[ \t]*\r?\n([\s\S]*?)(?:\r?\n)?---[ \t]*(?:\r?\n
  * given and never removes them, so the singleton would grow for as long as the
  * tab is open and hold on to every manager it ever saw.
  */
-export function registerFrontmatterTokenizer(instance: typeof marked): void {
+export function registerFrontmatterTokenizer(instance: Marked): void {
   instance.use({
     extensions: [
       {

packages/web-pkg/src/editor/extensions/markdownLists.ts

@@ -1,7 +1,7 @@
 import type { JSONContent, MarkdownToken } from '@tiptap/core'
 import { ListItem, OrderedList } from '@tiptap/extension-list'
 import { Tokenizer } from 'marked'
-import type { marked } from 'marked'
+import type { Marked } from 'marked'
 
 function isEmptySubItemUnderline(token?: MarkdownToken): boolean {
   // `- text` followed by `  -` lexes as a setext heading, not as an empty sub item
@@ -118,7 +118,7 @@ const emptyFirstItemPattern = /^( {0,3}(?:[-+*]|\d{1,9}[.)]))[ \t]+(?=\n|$)/
  *
  * Takes the instance as an argument for the same reason as `registerFrontmatterTokenizer`.
  */
-export function registerMarkdownListTokenizer(instance: typeof marked): void {
+export function registerMarkdownListTokenizer(instance: Marked): void {
   instance.use({
     tokenizer: {
       list(src) {

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/basics.md

@@ -0,0 +1,45 @@
+---
+title: Fixtures
+tags: [a, b]
+---
+
+# Heading 1
+
+## Heading 2
+
+Setext heading
+==============
+
+Text with *emphasis*, __strong__, ~~strike~~, `code` and a [link](https://opencloud.eu "title").
+A second line with a hard break  
+after it.
+
+![image](https://opencloud.eu/logo.png)
+
+> A quote
+> with two lines
+>
+> > nested
+
+***
+
+* bullet
+* list
+  + nested
+
+1. ordered
+2. list
+
+- [ ] open task
+- [x] done task
+
+| left | center | right |
+|:-----|:------:|------:|
+| a | b | c |
+| `d` | **e** | [f](#f) |
+
+```js
+const x = 1
+```
+
+    indented code

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/basics.out.md

@@ -0,0 +1,48 @@
+---
+title: Fixtures
+tags: [a, b]
+---
+
+# Heading 1
+
+## Heading 2
+
+# Setext heading
+
+Text with *emphasis*, **strong**, ~~strike~~, `code` and a [link](https://opencloud.eu "title").
+A second line with a hard break  
+after it.
+
+![image](https://opencloud.eu/logo.png)
+
+> A quote
+> with two lines
+>
+> > nested
+
+---
+
+- bullet
+- list
+  - nested
+
+1. ordered
+2. list
+
+- [ ] open task
+- [x] done task
+
+
+| left | center | right   |
+| :---- | :------: | -------: |
+| a    | b      | c       |
+| `d`  | **e**  | [f](#f) |
+
+
+```js
+const x = 1
+```
+
+```
+indented code
+```

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/blockquote-alert.md

@@ -0,0 +1,2 @@
+> [!NOTE]
+> hint

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/blockquote-escaped-alert-marker.md

@@ -0,0 +1,3 @@
+> \[!NOTE\](x) text
+
+> \[!NOTE\] text

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/code-block-fence-indented-1-space.md

@@ -0,0 +1,3 @@
+ ```
+ code
+ ```

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/code-block-fence-indented-1-space.out.md

@@ -0,0 +1,3 @@
+```
+code
+```

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/code-block-fence-indented-2-spaces.md

@@ -0,0 +1,4 @@
+  ```
+   code
+    x
+  ```

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/code-block-fence-indented-2-spaces.out.md

@@ -0,0 +1,4 @@
+```
+ code
+  x
+```

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/code-block-indented-fence-after-list.md

@@ -0,0 +1,4 @@
+- a
+ ```
+ code
+ ```

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/code-block-indented-fence-after-list.out.md

@@ -0,0 +1,5 @@
+- a
+
+```
+code
+```

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-asterisk-markers.md

@@ -0,0 +1,2 @@
+* a
+* b

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-asterisk-markers.out.md

@@ -0,0 +1,2 @@
+- a
+- b

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-blockquote-in-item.md

@@ -0,0 +1,2 @@
+- > quote
+- b

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-blockquote-in-item.out.md

@@ -0,0 +1,3 @@
+-  
+  > quote
+- b

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-empty-first-item.md

@@ -0,0 +1,2 @@
+- 
+- b

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-empty-first-item.out.md

@@ -0,0 +1,2 @@
+-
+- b

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-empty-first-ordered-sub-item.md

@@ -0,0 +1,3 @@
+- a
+  1. 
+  2. b

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-empty-first-ordered-sub-item.out.md

@@ -0,0 +1,3 @@
+- a
+  1.  
+  2. b

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-empty-item-in-blockquote.md

@@ -0,0 +1 @@
+> - 

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-empty-item-in-blockquote.out.md

@@ -0,0 +1 @@
+> -

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-empty-item-with-sub-list.md

@@ -0,0 +1,2 @@
+- 
+  - x

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-empty-item-with-sub-list.out.md

@@ -0,0 +1,2 @@
+-  
+  - x

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-empty-item.md

@@ -0,0 +1 @@
+- 

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-empty-item.out.md

@@ -0,0 +1 @@
+-

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-empty-items.md

@@ -0,0 +1,6 @@
+- a
+- 
+- b
+
+1. 
+2. b

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-empty-items.out.md

@@ -0,0 +1,6 @@
+- a
+-
+- b
+
+1.
+2. b

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-empty-last-ordered-item.md

@@ -0,0 +1,2 @@
+1. a
+2. 

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-empty-last-ordered-item.out.md

@@ -0,0 +1,2 @@
+1. a
+2.

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-empty-last-sub-item.md

@@ -0,0 +1,3 @@
+- a
+  - b
+  - 

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-empty-last-sub-item.out.md

@@ -0,0 +1,3 @@
+- a
+  - b
+  -

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-empty-sub-item-with-children.md

@@ -0,0 +1,8 @@
+- Parent
+  -  
+    - x
+  - c
+
+- a
+  -  
+    - x

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-empty-sub-item-with-children.out.md

@@ -0,0 +1,7 @@
+- Parent
+  -  
+    - x
+  - c
+- a
+  -  
+    - x

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-empty-sub-items.md

@@ -0,0 +1,9 @@
+- Parent
+  -  
+  - c
+- Next
+
+1. Parent
+   -  
+   - c
+2. Next

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-escaped-lines-in-item.md

@@ -0,0 +1,3 @@
+- a
+  2\. b
+  Dr\. Smith

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-escaped-lines-in-item.out.md

@@ -0,0 +1,3 @@
+- a
+2\. b
+Dr\. Smith

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-heading-below-empty-marker.md

@@ -0,0 +1,3 @@
+-
+  # Title
+- b

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-heading-below-empty-marker.out.md

@@ -0,0 +1,3 @@
+-  
+  # Title
+- b

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-heading-in-item.md

@@ -0,0 +1,2 @@
+- # Title
+- b

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-heading-in-item.out.md

@@ -0,0 +1,3 @@
+-  
+  # Title
+- b

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-heading-in-letter-item.md

@@ -0,0 +1,3 @@
+a. 
+   # Title
+b. y

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-heading-in-letter-item.out.md

@@ -0,0 +1,3 @@
+a.  
+   # Title
+b. y

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-heading-in-ordered-item.md

@@ -0,0 +1,2 @@
+1. # Title
+2. b

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-heading-in-ordered-item.out.md

@@ -0,0 +1,3 @@
+1.  
+   # Title
+2. b

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-image-after-text.md

@@ -0,0 +1,3 @@
+- a
+
+  ![a](http://x/a.png)

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-image-item.md

@@ -0,0 +1,6 @@
+- ![a](http://x/a.png)
+  - sub
+- a
+- ![b](http://x/b.png)
+
+1. ![c](http://x/c.png)

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-item-escaped-marker.md

@@ -0,0 +1 @@
+1. \-

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-letters-empty-item.md

@@ -0,0 +1,3 @@
+a. one
+b. 
+c. three

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-letters-empty-item.out.md

@@ -0,0 +1,3 @@
+a. one
+b.  
+c. three

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-literal-nbsp.md

@@ -0,0 +1,9 @@
+-  
+
+text
+
+-  
+  - x
+
+a.  
+b. two

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-lowercase-letters.md

@@ -0,0 +1,2 @@
+a. one
+b. two

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-lowercase-roman-numerals.md

@@ -0,0 +1,2 @@
+i. one
+ii. two

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-ordered-content-indented-2-spaces.md

@@ -0,0 +1,3 @@
+1. a
+
+  more

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-ordered-content-indented-2-spaces.out.md

@@ -0,0 +1,3 @@
+1. a
+
+more

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-ordered-continuation-line.md

@@ -0,0 +1,2 @@
+1. a
+  b

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-ordered-continuation-line.out.md

@@ -0,0 +1,2 @@
+1. a
+b

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-ordered-item-escaped-line.md

@@ -0,0 +1,10 @@
+1. a
+   12345678901\. b
+2. a
+   B\. b
+3. a
+   2\. b
+4. a
+   \- b
+5. a
+   \# b

packages/web-pkg/tests/unit/editor/strategies/fixtures/markdown/list-ordered-item-escaped-line.out.md

@@ -0,0 +1,10 @@
+1. a
+12345678901\. b
+2. a
+B\. b
+3. a
+2\. b
+4. a
+\- b
+5. a
+\# b