Repository navigation
fix(design-system): OcSwitch keeps its focus, OcMobileDrop takes it when opened - #3627
Merged
Merged
Conversation
…rop takes the focus OcSwitch was keyed by its state, so every toggle rendered a new button and the focus was lost (keyboard users, a second Space did nothing). The mobile drop now focuses its drawer when opened, like the drop on larger screens, so Escape closes the drawer instead of reaching the page behind it (e.g. AppWrapper, which closed the app).
JammingBen
approved these changes
Oct 12, 2026
openclouders
pushed a commit
that referenced
this pull request
Oct 12, 2026
…rop takes the focus (#3627) OcSwitch was keyed by its state, so every toggle rendered a new button and the focus was lost (keyboard users, a second Space did nothing). The mobile drop now focuses its drawer when opened, like the drop on larger screens, so Escape closes the drawer instead of reaching the page behind it (e.g. AppWrapper, which closed the app).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two focus bugs in the design system, found while testing PDF Studio (web-extensions):
checkedstate, so every toggle rendered a new button and the focus fell to the body. Keyboard users lost their place, a second Space did nothing and Escape no longer reached a surrounding drop. The key is gone, the styles only depend onaria-checked, so the switch looks the same.checked/update:checkedonly, none relies on the re-creation. Content in the label slot (e.g. a contextual helper) is no longer re-created on toggle either, so an open helper stays open.OcDropdoes on larger screens.Related Issue
How Has This Been Tested?
Types of changes