Repository navigation
fix: close embedded pickers with Escape - #3630
Open
AlexAndBear wants to merge 1 commit into
Open
AlexAndBear wants to merge 1 commit into
AlexAndBear wants to merge 1 commit into
Conversation
AlexAndBear
marked this pull request as ready for review
October 9, 2026 19:05
AlexAndBear
force-pushed
the
fix/embed-escape-cancel
branch
from
October 9, 2026 19:07
b1bdfa2 to
bcea1ed
Compare
Pickers embed the files app in an iframe and move the focus into it, so the Escape handling of the surrounding modal never gets the key. Escape now cancels in embed mode like the cancel button, via the keyboard actions of web-pkg.
AlexAndBear
force-pushed
the
fix/embed-escape-cancel
branch
from
October 9, 2026 19:11
bcea1ed to
e0d3812
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The file picker, location picker and "Save as" dialog of apps embed the files app in an iframe and move the focus into it. Key events of an iframe stay in its document, so the Escape handling of the surrounding modal never gets them – Escape did nothing.
In embed mode, Escape now cancels like the cancel button (posts
opencloud-embed:cancel), bound viauseKeyboardActions, so it works for all three pickers and any other embedding – like Escape in native file dialogs. As with all keyboard actions, it doesn't apply while a text field has the focus or a modal is open inside the embedded app.Related Issue
How Has This Been Tested?
EmbedActions.spec.tsTypes of changes