Repository navigation
fix: no image from the cloud in the text editor on public links - #3632
Merged
Merged
Conversation
On public links the file picker only shows the shared files, for links to a single file just the edited file itself, so there is nothing to pick.
Member
Author
|
On folder links, picking an image from the shared folder could actually be useful, so ideally the action would only be hidden for links to a single file. That isn't possible yet: the root of every public link reports |
JammingBen
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On public links, the text editor offered "Insert image" → "Insert from cloud", but the file picker can't offer anything useful there: it opens the parent folder of the edited file and an anonymous user can't browse anywhere else – for links to a single file, the picker only shows the edited file itself.
"Insert from cloud" is now hidden on public links (
publicLinkContextReadyof the auth store, likeisPublicLinkContextofuseAppDefaults), in the image dropdown and in the slash commands. "Image from file" and "Image from URL" stay available.Related Issue
How Has This Been Tested?
pnpm check:typesTypes of changes