Skip to content

Feat/runner resources - #51

Merged
amh1k merged 5 commits into
mainfrom
feat/runner-resources
Oct 14, 2026
Merged

amh1k merged 5 commits into
mainfrom
feat/runner-resources

Conversation

@amh1k

@amh1k amh1k commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Closes #41. Allow users to set CPU and memory requests and limits for individual benchmark jobs.

Changes

  • Add optional CPU and memory fields under Job resources in the benchmark form. Empty fields inherit the deployment defaults.
  • Validate resource values and apply per-run overrides to the Kubernetes pgbench Job.
  • Save the resolved resources with each run and display them alongside its status and results. These are configured resources, not measured usage.
  • Add backend and frontend tests for defaults, overrides, validation, and run-status responses.

Verification

  • npm run build
  • npm run test:form

Video

2026-10-08.21-47-28.mp4

@spron-in spron-in left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few follow-ups on the resources UI and API types; suggestions inline.

Comment thread src/BenchmarkForm.tsx Outdated
Comment thread backend/internal/api/runs.go Outdated
Comment thread backend/internal/coordinator/resources.go
Comment thread src/BenchmarkForm.tsx
Signed-off-by: amh1k <abdulmoizx97@gmail.com>
@amh1k
amh1k merged commit 0ee582c into main Oct 14, 2026
5 checks passed
@amh1k
amh1k deleted the feat/runner-resources branch October 14, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set resources for bench jobs

2 participants