fix: OpenFGA SDK doesn't seem to support async_req parameter#253
Open
Abishek-Newar wants to merge 7 commits into
Open
fix: OpenFGA SDK doesn't seem to support async_req parameter#253Abishek-Newar wants to merge 7 commits into
Abishek-Newar wants to merge 7 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What problem is being solved?
The
async_reqparameter exists in the lower-levelapi_client.pyto enable threading-based asynchronous requests using Python'sThreadPool. However, this parameter is not exposed through the publicOpenFgaClientAPI because theoptions_to_kwargsfunction doesn't support it, making it inaccessible without using internal APIs.How is it being solved?
Updated the
options_to_kwargsfunction to pass through theasync_reqparameter from user options to the underlying API calls.What changes are made to solve it?
async_reqparameter support inopenfga_sdk/sync/client/client.py(sync client)After this change, users can use
async_reqlike this:References
closes #194
Review Checklist
mainSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.