Repository navigation
i18n: add Polish (pl) interface language - #901
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 1
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
|
| Layer / File(s) | Summary |
|---|---|
Register and test Polish crates/ui-egui/src/i18n/mod.rs, crates/ui-egui/src/i18n/tests.rs |
The public LANGUAGES registry grows to 19 entries and adds Polish. Tests cover locale resolution, language metadata, the “Open” translation, and English fallback for a missing string. |
Update language counts and table README.md, GEOLIBRE_PARITY.md, docs/i18n.md, docs/sponsor.md, docs/user-guide/workspace.md |
The language count changes from 18 to 19. The i18n table adds Polish and rearranges several existing entries. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Feature
Possibly related PRs
- opengeos/RustGIS#803: Adds Bengali to the same language registry and tests; this change extends that registry.
- opengeos/RustGIS#847: Updates the same language-count references and i18n table before this change.
Suggested reviewers: sophisticatedstupid, giswqs
Merge Risk: 
Minimal · up to 57734
-
The Polish language addition is mergeable with no identified current risk.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passed-
Full details: Description check
-
Explanation
The description includes complete Summary, Testing, and Related issue sections. It explains the catalog, registration, tests, documentation updates, validation results, and the known unrelated GDAL failure.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. (5 skipped: 5 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A Polish word joins the list,
Its locale finds its place,
“Open” speaks in Polish,
Missing words fall back with grace,
A rabbit counts to nineteen,
Then hops through every page.
Comment @coderabbitai help to get the list of available commands.
Code reviewThis PR adds a Polish ( Bugs
Security
Performance
Quality
AGENTS.md
Change sizeCompared: the whole PR against main (merge base 6ef386d to PR head 2e63489).
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@coderabbitai approve |
✅ Action performed
|
📖 Docs preview
GitHub Pages takes a minute or two to publish a new commit. Newer commits from the fork aren't published until a maintainer adds the |
Summary
Adds Polish as an interface language.
crates/ui-egui/src/i18n/pl.tsv: the full Polish catalog, all 3,562 strings of the English source, UTF-8 with CRLF as the sibling catalogs use. A Polish system locale now opens RustGIS in Polish instead of falling back to English.crates/ui-egui/src/i18n/mod.rs: registerslang!("pl", "Polski", "Polish", Script::Alphabetic, "pl.tsv")and raisesLANGUAGESto 19. Latin script, so no font download and noscript_regionchange.crates/ui-egui/src/i18n/tests.rs:pl_PL.UTF-8locale detection, plus a registration and English-fallback test.docs/i18n.md(table row and count),docs/sponsor.md,docs/user-guide/workspace.md, the README badge and Interface row, andGEOLIBRE_PARITY.md.Testing
cargo fmt --all --check: pass.cargo clippy --workspace --all-targets -- -D warnings: pass.cargo xtask layers: pass.pre-commit run --all-files: pass.cargo test -p rustgis-ui-egui i18n: 23 passed, including the mandatory-translation and placeholder-parity tests. The wholerustgis-ui-eguisuite passes: 388 library tests and 86 smoke tests.cargo test --workspace: every crate passes exceptrustgis-data'sfilegdb::tests::reads_what_gdal_writes_when_gdal_is_installedon this machine. That test fails identically on unmodifiedmainhere, because the local GDAL 3.9.2 cannot write a TINZ layer into an OpenFileGDB ("Can only insert a Polygon/MultiPolygon..."). This change touches no file incrates/data.\nescapes match the English ribbon labels, 3,562 of 3,562 entries translated.RUSTGIS_LANGUAGE=plon Windows and read the menus, tabs, ribbon and status bar in Polish.Terminology sources: the QGIS Polish translation catalog for the interface vocabulary, published Esri Poland documentation for geoprocessing terms, and Polish-language geostatistics literature for the analysis terms. Two labels (Swipe, Perceptually uniform) have no retrievable Polish source and use a descriptive rendering.
Related issue
No existing issue for Polish. This change does not touch the data model, dependencies, the
.rgisproject format, command ids or the plugin interface, so it is opened directly as a pull request perCONTRIBUTING.md.Summary by CodeRabbit