relay: (d18+)Reject unsupported Mandatory Track Properties (draft-18 … - #697
Draft
akash-a-n wants to merge 1 commit into
Draft
relay: (d18+)Reject unsupported Mandatory Track Properties (draft-18 …#697akash-a-n wants to merge 1 commit into
akash-a-n wants to merge 1 commit into
Conversation
akash-a-n
added this pull request to stack #698
September 9, 2026 13:27
…§2.5.1) Add hasUnsupportedMandatoryProperty() (src/relay/TrackProperties.h), a shared helper that flags any extension in the 0x4000-0x7FFF Mandatory Track Property range across both the mutable and immutable extension lists — moqx currently understands none of them. Wire the check into the three places a peer can hand the relay a mandatory property it can't honor: - PUBLISH: publish() and publishFromPublisherExec() reject the request with UNSUPPORTED_EXTENSION before installing a forwarder. - SUBSCRIBE_OK: subscribeUpstreamAndApplyOk() rejects the downstream subscribe if the upstream's OK carries one, instead of applying it to the forwarder. - FETCH_OK: MoqxCache::fetchUpstream() rejects the fetch and resets the consumer's stream if the upstream's FetchOk carries one, including on the detached background-task path taken when the fast path (live track / known past data) already returned FETCH_OK synchronously.
akash-a-n
force-pushed
the
d18/mandatory-track-extension
branch
from
September 9, 2026 15:37
bdb181c to
ccc5514
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…§2.5.1)
Add hasUnsupportedMandatoryProperty() (src/relay/TrackProperties.h), a shared helper that flags any extension in the 0x4000-0x7FFF Mandatory Track Property range across both the mutable and immutable extension lists — moqx currently understands none of them.
Wire the check into the three places a peer can hand the relay a mandatory property it can't honor:
This change is