Repository navigation
fix(cron): clear scheduled jobs when sessions change - #738
Open
outlier27-cell wants to merge 1 commit into
Open
outlier27-cell wants to merge 1 commit into
outlier27-cell wants to merge 1 commit into
Conversation
Contributor
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
/crondocuments scheduled prompts as session-scoped, but a second Pisession_startretained the preceding session's in-memory jobs. A due old-session prompt could therefore be delivered after/newor/resume.Value
Scheduled prompts now remain owned by the session where the user created them, preventing cross-session follow-ups.
Approach
session_start, absence of the old job, and normal scheduling in the new session.Validation
node --test --experimental-strip-types tests/extensions/cron/index.test.ts tests/extensions/cron/schedule.test.ts(23 passed)bun run check(passed: config/docs/disciplines, Web build, format, lint, and typecheck)bun run testwas started, but unrelated Git/process, renderer, and workflow tests failed under the Windows parallel runner and the run later stalled. The cron suite itself passed in that run. Exact-head GitHub CI is required before merge.Impact
No persistent state, provider behavior, or model-facing surface changes. Existing jobs are intentionally cleared whenever Pi begins a new session lifecycle.
Closes #736