Repository navigation
fix(cursor): bound protobuf map entries - #739
Open
outlier27-cell wants to merge 1 commit into
Open
outlier27-cell wants to merge 1 commit into
outlier27-cell wants to merge 1 commit into
Conversation
Contributor
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cursor protobuf map decoding kept reading from the outer message after a map entry's declared length. A malformed entry could therefore consume later bytes as its value.
Closes #735
Value
Malformed catalog protobuf input now fails at the entry boundary instead of silently producing a map value from unrelated bytes.
Approach
Reader.Validation
node --test --experimental-strip-types tests/extensions/ai-providers/cursor-protobuf.test.ts tests/extensions/ai-providers/cursor.test.ts(38 passing)bun run checkbun run testwas started; the unmodified full suite reproduced existing renderer-chain failures before it was stopped. Exact-head GitHub CI is tracked for the final cross-platform result.Impact
No configuration or user-visible workflow changes. The Cursor protobuf decoder rejects malformed map entries more accurately.