Repository navigation
fix(tui): avoid stacking editor layers on session start - #741
Open
outlier27-cell wants to merge 2 commits into
Open
outlier27-cell wants to merge 2 commits into
outlier27-cell wants to merge 2 commits into
Conversation
Contributor
Author
|
@tt-a1i 请审核此 PR。当前精确提交的 GitHub CI 已全部通过,修改范围与回归测试均已在 PR 说明中列明;现仅等待维护者审核。 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Repeated Pi
session_startevents on one TUI context rebuilt OpenPI's editor factory from the already-wrapped factory. Each/new,/resume, or/reloadcould therefore stack every registered editor layer again.Closes #740
Value
The active editor keeps one composition of each OpenPI layer across session starts, preventing duplicated editor behavior and nested rendering overhead.
Approach
Validation
node --test --experimental-strip-types tests/extensions/shared/editor-layers.test.ts(2 passing)bun run checkbun run testreproduced existing failures in unmodified clear-context, renderer-chain, and Git fixture suites; the new editor-layer regression passed before the run was stopped. Exact-head GitHub CI is tracked for the final cross-platform result.Impact
No new UI surface or configuration. Editor layers retain their existing registration order and lifecycle while repeated session starts remain idempotent.