Repository navigation
prted: name the session server's file by a rendezvous ID - #2878
Merged
Merged
Conversation
openpmix#2877 gave a DVM's controller and daemons an ID of their own making and passed it to PMIx_server_init as PMIX_SESSION_ID, since PMIx named a session server's rendezvous file by that. But PMIX_SESSION_ID is the session's ID as the scheduler assigned it, which clients and tools read as such; the DVM's computed value does not belong there. PMIx now takes the ID that names the file as its own attribute, PMIX_SESSION_RNDZ_ID, falling back to PMIX_SESSION_ID when it is not given. Pass the computed ID as PMIX_SESSION_RNDZ_ID, when the PMIx defines it, and nothing as PMIX_SESSION_ID. A PMIx without the attribute names no session server's file by an ID, so there is nothing to pass. Rename what openpmix#2877 added to match: the MCA parameter pmix_session_id is now pmix_session_rndz_id, and prte_pmix_server_compute_session_id is prte_pmix_server_compute_rndz_id. Neither has been in a release. Signed-off-by: Ralph Castain <rhc@pmix.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2877 gave a DVM's controller and daemons an ID of their own making and passed it to
PMIx_server_initasPMIX_SESSION_ID, because PMIx named a session server's rendezvous file by that attribute. ButPMIX_SESSION_IDis the session's ID as the scheduler assigned it, and clients and tools read it as such. The DVM's computed value doesn't belong there.openpmix/openpmix#4385 adds
PMIX_SESSION_RNDZ_ID, which only names the rendezvous file, and falls back toPMIX_SESSION_IDwhen it isn't given.Change
Pass the computed ID as
PMIX_SESSION_RNDZ_IDwhen the PMIx defines it, and nothing asPMIX_SESSION_ID. A PMIx without the attribute names no session server's file by an ID, so there is nothing to pass.Rename what prted: name the session a DVM is the session server of #2877 added to match:
pmix_session_idis nowpmix_session_rndz_id;prte_pmix_server_compute_session_id()is nowprte_pmix_server_compute_rndz_id().Neither has been in a release.
This PR and openpmix/openpmix#4385 can merge in either order. Against PMIx master as it is now, PRRTE builds and passes nothing. Against #4385 before this PR, the fallback names the file by the
PMIX_SESSION_IDthat #2877 passes.Testing
prterunbeside them all start, each DVM's file is named by its own ID,--pidreaches either DVM, andprunwith no target lists both;PMIX_SRCset to that branch: 936 passed, 0 failed, 3 skipped.