Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes on numeric strings
Some values that look numeric are intentionally documented as strings because that is the current live API behavior. This is a bit weird, but it is correct right now.
Examples include MySQL computed/aggregate values such as:
spotifyPlaysSum.spotify_startsspotifyPlaysSum.spotify_streamsspotifyPlaysSum.spotify_listenersspotify_listeners_percent,quarter1_combined, and Apple LTR quarter valuesI verified this against
https://api.openpodcast.devwith podcast ID 16. For example,spotifyPlaysSumcurrently returns:{ "podcast_id": 16, "spotify_total_episodes": "49", "spotify_starts": "99942", "spotify_streams": "76882", "spotify_listeners": "8389", "spotify_followers": "3626" }The report app also already handles this behavior in practice, e.g. by parsing values for charts and by formatting numeric strings in gauges. A future API cleanup could normalize these fields to numbers where safe, but this PR documents the API shape as it exists today.
Validation
npm run buildnpx prettier --check src/config/generate-query-docs.ts src/config/query-examples.tshttp://localhost:8080/api-docs.json-> 200http://localhost:8080/api-docs/-> 200