Skip to content

Improve test coverage for LombokValToFinalVar - #1230

Merged
greg-at-moderne merged 1 commit into
openrewrite:mainfrom
sullis:ss-lombok-val-to-final-var-sept1
Sep 2, 2026
Merged

Improve test coverage for LombokValToFinalVar#1230
greg-at-moderne merged 1 commit into
openrewrite:mainfrom
sullis:ss-lombok-val-to-final-var-sept1

Conversation

@sullis

@sullis sullis commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Adds a test covering lombok.val inside a nested lambda, where the lambda parameter shadows a field of the same name.

The recipe correctly rewrites val key = ... to final var key = ... and removes the now-unused lombok.val import, leaving the shadowing lambda parameter untouched.

Recipe

https://docs.openrewrite.org/recipes/java/migrate/lombok/lombokvaltofinalvar

🤖 Generated with Claude Code

@github-project-automation github-project-automation Bot moved this to In Progress in OpenRewrite Sep 1, 2026
@sullis
sullis force-pushed the ss-lombok-val-to-final-var-sept1 branch from 708c2d0 to 3ef9ffc Compare September 1, 2026 21:20
@sullis
sullis force-pushed the ss-lombok-val-to-final-var-sept1 branch from 3ef9ffc to c077b8c Compare September 2, 2026 12:42
@sullis

sullis commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

CI is green. Ready for review / feedback @greg-at-moderne

@greg-at-moderne greg-at-moderne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for coming up with this one.

@github-project-automation github-project-automation Bot moved this from In Progress to Ready to Review in OpenRewrite Sep 2, 2026
@greg-at-moderne
greg-at-moderne merged commit 4ae4bdb into openrewrite:main Sep 2, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from Ready to Review to Done in OpenRewrite Sep 2, 2026
@sullis
sullis deleted the ss-lombok-val-to-final-var-sept1 branch September 2, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants