Fix RemoveUnusedImports crash on static wildcard from capitalized packages - #8655
Open
kalayciburak wants to merge 1 commit into
Conversation
…kages Unfold using the fuzzy type-name match when getTypeName() treats a capitalized package segment as a nested class, and skip the empty-list write that threw IndexOutOfBoundsException. Fixes openrewrite#8654
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Unfold a static star import using the fuzzy type-name match when
getTypeName()treats a capitalized package segment as a nested class. That lookup used to miss, leave the unfolded list empty, and throwIndexOutOfBoundsException. The empty-list write is also skipped, matching the non-static wildcard branch.What's your motivation?
Have you considered any alternatives or workarounds?
J.Import.getTypeName()itself would help other call sites, but it is a broader heuristic change. Named static imports already use theorg.openrewrite.java.RemoveUnusedImportsremoves used imports #1698 fuzzy match. Unfolding now uses the same members.Checklist
./gradlew :rewrite-java-test:test --tests org.openrewrite.java.RemoveUnusedImportsTestlocally (77 tests, 2 skipped, 0 failures). Norecipes.csvchange.