Fix Java parser corruption for inferred lambda parameters - #8709
Open
sebastianhaeni wants to merge 2 commits into
Open
Fix Java parser corruption for inferred lambda parameters#8709sebastianhaeni wants to merge 2 commits into
sebastianhaeni wants to merge 2 commits into
Conversation
timtebeek
reviewed
Aug 28, 2026
Comment on lines
+1773
to
+1774
| if (!hasLombokGeneratedSymbol(node)) { | ||
| // Inferred lambda parameter types and unresolved types have no source representation. |
Member
There was a problem hiding this comment.
Cross linking to make review easier:
Member
|
Thanks a lot for the immediately proposed fix @sebastianhaeni ! I've kicked off CI, but will be out for three weeks after today, so I'll leave it up to colleagues to review and merge. 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
var/val.var/valparsing behavior.What's your motivation?
Anything in particular you'd like reviewers to focus on?
Please review whether
hasLombokGeneratedSymbol(node)is the appropriate discriminator across all supported Java parser versions.Checklist
./gradlew buildlocally, and committed any resulting changes torecipes.csv(targeted compatibility tests were run instead)