Accept the full packument as a fallback to avoid registry HTTP 406 - #8710
Open
bmuschko wants to merge 1 commit into
Open
Accept the full packument as a fallback to avoid registry HTTP 406#8710bmuschko wants to merge 1 commit into
bmuschko wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Regenerating an npm lock file requests the abbreviated packument with only
Accept: application/vnd.npm.install-v1+json. A registry that does not serve that media type (for example some Artifactory npm proxies) responds withHTTP 406, which surfaces asREGISTRY_UNREACHABLEand aborts dependency resolution, even though the registry can serve the full packument.Fix
Mirror npm's own
Acceptheader and request the full packument as a fallback:application/vnd.npm.install-v1+json; q=1.0, application/json; q=0.8, */*. A registry that cannot serve the abbreviated form now returns the full packument instead of a 406. The packument parser already tolerates the full document.