Make minimum UID/GID configurable via multiuser.minuid/mingid#69
Open
djw8605 wants to merge 1 commit into
Open
Make minimum UID/GID configurable via multiuser.minuid/mingid#69djw8605 wants to merge 1 commit into
djw8605 wants to merge 1 commit into
Conversation
The UID/GID thresholds below which a mapped username is rejected as a system account were hard-coded to 500 (g_minimum_uid / g_minimum_gid). Sites that mount shared file systems (e.g. Lustre) may have legitimate groups with IDs below 500, which were being denied access. Convert the thresholds to static members of UserSentry (single definition with external linkage, mirroring m_is_cmsd) so a value set at config time is seen across all translation units, and parse two new optional config directives, multiuser.minuid and multiuser.mingid, in MultiuserFileSystem::Config(). Both default to 500, preserving existing behavior. The effective thresholds are logged at startup. Closes #68 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UFwX4qfurnnEvbPtzL46ZL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UID/GID thresholds below which a mapped username is rejected as a
system account were hard-coded to 500 (g_minimum_uid / g_minimum_gid).
Sites that mount shared file systems (e.g. Lustre) may have legitimate
groups with IDs below 500, which were being denied access.
Convert the thresholds to static members of UserSentry (single definition
with external linkage, mirroring m_is_cmsd) so a value set at config time
is seen across all translation units, and parse two new optional config
directives, multiuser.minuid and multiuser.mingid, in
MultiuserFileSystem::Config(). Both default to 500, preserving existing
behavior. The effective thresholds are logged at startup.
Closes #68
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01UFwX4qfurnnEvbPtzL46ZL