Repository navigation
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 35 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #103 +/- ##
==========================================
+ Coverage 69.92% 69.99% +0.08%
==========================================
Files 5 5
Lines 585 673 +88
Branches 136 158 +22
==========================================
+ Hits 409 471 +62
- Misses 109 121 +12
- Partials 67 81 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
I know it is tricky to cover protocol details ..., just plz review and provide aspects you can capture. you can also rely on tests and local deletion tests on some random pdf files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#51
What does this implement/fix? Explain your changes.
In this PR, I've added support for PDF format.
Also, I've updated
tests/conftest.pyto basically be format agnostic and the whole point of it is that, so within our tests, when I run locally, the clean OR update inin-placemode, cleans/updates the metadata on the test files and I did this update on conftest, to be format agnostic and also the whole point of it is just to have test files untouched and also keep the tests properly running end to end (so I don't need to manually undo changes on it).Any other comments?