Skip to content

Refactor - #113

Merged
sadrasabouri merged 9 commits into
devfrom
refactor
Nov 2, 2026
Merged

sadrasabouri merged 9 commits into
devfrom
refactor

Conversation

@sepandhaghighi

@sepandhaghighi sepandhaghighi commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • _play_cli function moved to cli.py
  • Test system modified
  • Noisy comments removed
  • OVERVIEW updated

Any other comments?

Local tests on OSs

  • macOS
    • Sonoma
  • Windows
    • Windows 11
  • Linux
    • Ubuntu 22.04

@sepandhaghighi sepandhaghighi added this to the nava v1.0 milestone Nov 1, 2026
@sepandhaghighi sepandhaghighi self-assigned this Nov 1, 2026
@codacy-production

codacy-production Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.58%. Comparing base (989048c) to head (05d0552).

Files with missing lines Patch % Lines
nava/cli.py 90.91% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #113      +/-   ##
==========================================
+ Coverage   89.55%   89.58%   +0.04%     
==========================================
  Files           5        5              
  Lines         306      307       +1     
  Branches       39       39              
==========================================
+ Hits          274      275       +1     
  Misses         25       25              
  Partials        7        7              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sepandhaghighi
sepandhaghighi marked this pull request as ready for review November 2, 2026 14:18
@sadrasabouri
sadrasabouri merged commit 9424b05 into dev Nov 2, 2026
34 checks passed
@sadrasabouri
sadrasabouri deleted the refactor branch November 2, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants