Skip to content

Add/xgboost - #314

Open
AHReccese wants to merge 39 commits into
devfrom
add/xgboost
Open

AHReccese wants to merge 39 commits into
devfrom
add/xgboost

Conversation

@AHReccese

Copy link
Copy Markdown
Member

Reference Issues/PRs

#221

What does this implement/fix? Explain your changes.

Any other comments?

…line integration and JSON serialization checks.
…ression and binary classification objectives.
…model performance before and after streaming.
…nctions and ensure directory creation for file exports.
…g functions to handle generic ML model types.
@AHReccese AHReccese self-assigned this Nov 3, 2026
@codacy-production

codacy-production Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 346 complexity

Metric Results
Complexity 346

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@AHReccese AHReccese added bug Something isn't working new feature major major changes, to be reviewed in 10 days labels Nov 3, 2026
@AHReccese AHReccese added this to the pymilo v1.7 milestone Nov 3, 2026
@AHReccese

AHReccese commented Nov 3, 2026 •

Copy link
Copy Markdown
Member Author

@AHReccese As the very first feedback cycle:

1- update & restructure README.md to better explain installation mode, I know the current README.md here is a temp one, but it must be properly updated before merge.

2- in a separate PR, add _ to functions other than API we expose, to flag being internal.
3- check on practice for libomp system dependency
4- I've enabled codacy on dev, apply 5 issues it is flagging.

@codecov

codecov Bot commented Nov 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.25571% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.37%. Comparing base (06716ac) to head (64a6a4f).
⚠️ Report is 161 commits behind head on dev.

Files with missing lines Patch % Lines
pymilo/utils/util.py 21.06% 15 Missing ⚠️
pymilo/pymilo_func.py 68.75% 8 Missing and 2 partials ⚠️
pymilo/transporters/booster_transporter.py 77.15% 5 Missing and 3 partials ⚠️
pymilo/chains/xgboost_chain.py 87.50% 6 Missing and 1 partial ⚠️
pymilo/transporters/preprocessing_transporter.py 77.78% 2 Missing and 2 partials ⚠️
pymilo/chains/util.py 62.50% 2 Missing and 1 partial ⚠️
pymilo/pymilo_obj.py 86.96% 1 Missing and 2 partials ⚠️
pymilo/pymilo_param.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #314       +/-   ##
===========================================
- Coverage   87.40%   75.37%   -12.02%     
===========================================
  Files          31       53       +22     
  Lines        1142     2813     +1671     
  Branches      201      498      +297     
===========================================
+ Hits          998     2120     +1122     
- Misses         90      573      +483     
- Partials       54      120       +66     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working major major changes, to be reviewed in 10 days new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant