Repository navigation
[rhaiis] Align accelerator labels in failure alerts - #302
Harshith-umesh merged 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughFailure notifications now pass the configured accelerator directly and keep the cluster tag separate. A test verifies the arguments passed by ChangesFailure notification arguments
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The failure alert uses the configured accelerator and keeps the cluster tag separate. No merge-blocking concern is evident from the supplied change context. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Use the configured accelerator value in failure and warning Slack notifications, matching successful-run notifications. Keep the cluster name in its separate field and cover the failure formatting with a regression test.
Validation: Ruff checks/format and projects/rhaiis/tests/test_slack_notifications.py.
Summary by CodeRabbit