Skip to content

[rhaiis] Align accelerator labels in failure alerts - #302

Merged
Harshith-umesh merged 1 commit into
openshift-psap:mainfrom
Harshith-umesh:codex/rhaiis-failure-accelerator-format
Oct 2, 2026
Merged

Harshith-umesh merged 1 commit into
openshift-psap:mainfrom
Harshith-umesh:codex/rhaiis-failure-accelerator-format

Conversation

@Harshith-umesh

@Harshith-umesh Harshith-umesh commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

Use the configured accelerator value in failure and warning Slack notifications, matching successful-run notifications. Keep the cluster name in its separate field and cover the failure formatting with a regression test.

Validation: Ruff checks/format and projects/rhaiis/tests/test_slack_notifications.py.

Summary by CodeRabbit

  • Bug Fixes
    • Pipeline failure alerts now use the configured accelerator value directly and pass the cluster tag separately. This keeps accelerator and cluster details distinct in notifications, rather than deriving a combined accelerator key from the GPU type and cluster tag. The change applies to pipeline failure notifications; other notification details are unchanged.

@openshift-ci

openshift-ci Bot commented Oct 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thameem-abbas for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 9947b993-20cf-4c8a-b2f0-0e19b1de50a9

📥 Commits

Reviewing files that changed from the base of the PR and between 0e8f050 and 1dd1ed8.

📒 Files selected for processing (3)
  • projects/rhaiis/orchestration/ci.py
  • projects/rhaiis/orchestration/notifications.py
  • projects/rhaiis/tests/test_slack_notifications.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Failure notifications now pass the configured accelerator directly and keep the cluster tag separate. A test verifies the arguments passed by _send_alert.

Changes

Failure notification arguments

Layer / File(s) Summary
Pass through accelerator and cluster tag
projects/rhaiis/orchestration/ci.py, projects/rhaiis/orchestration/notifications.py, projects/rhaiis/tests/test_slack_notifications.py
The notification path passes the configured accelerator instead of deriving an uppercased value from the GPU type and cluster tag. The test checks that _send_alert passes "amd" and "mi355x" separately.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 1dd1e

The failure alert uses the configured accelerator and keeps the cluster tag separate. No merge-blocking concern is evident from the supplied change context.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: aligning accelerator labels in rhaiis failure alerts.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Harshith-umesh
Harshith-umesh merged commit c26b265 into openshift-psap:main Oct 2, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant