Skip to content

[rhaiis] Scope profiler ranges to MI355X cluster - #303

Open
ssaketh-ch wants to merge 2 commits into
openshift-psap:mainfrom
ssaketh-ch:ssaketh-ch/cpt-mi355x-profiler-ranges
Open

ssaketh-ch wants to merge 2 commits into
openshift-psap:mainfrom
ssaketh-ch:ssaketh-ch/cpt-mi355x-profiler-ranges

Conversation

@ssaketh-ch

@ssaketh-ch ssaketh-ch commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Set rhaiis.profiler.ranges to 100-103 in the cluster_mi355x preset.
  • Remove the range override from the MI355X CPT definition, leaving the shared default at 500-503.

Motivation

  • Keep the profiler range specific to the MI355X target cluster.

Testing

  • Parsed the affected YAML files successfully.
  • git diff --check passed.
  • Runtime validation on a Fournos job has not been run.

@openshift-ci

openshift-ci Bot commented Oct 2, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ashishkamra for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: c5b8d24a-dca9-4c94-9af1-ea35d207cc25

📥 Commits

Reviewing files that changed from the base of the PR and between c26b265 and 5aec6fa.

📒 Files selected for processing (1)
  • projects/rhaiis/orchestration/cpt.d/cpt.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The MI355X pipeline now sets rhaiis.profiler.ranges to "100-103".

Changes

MI355X profiler configuration

Layer / File(s) Summary
Set profiler range
projects/rhaiis/orchestration/cpt.d/cpt.yaml
The MI355X pipeline sets rhaiis.profiler.ranges to "100-103".

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: harshith-umesh

Merge Risk: ⚪ Minimal · up to 5aec6

The change supplies the MI355X profiler range; the available context indicates it is propagated to the vLLM manifest when profiling is enabled. No actionable merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: it scopes profiler ranges for the MI355X RHAIIS configuration. The wording is concise and specific.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ssaketh-ch ssaketh-ch changed the title [rhaiis] Set MI355X CPT profiler ranges to 100-103 [rhaiis] Scope profiler ranges to MI355X cluster Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant