Skip to content

Fix B200 Grafana dashboard routing to pirate cluster - #102

Open
aas008 wants to merge 1 commit into
openshift-psap:mainfrom
aas008:fix/b200-grafana-dashboard-routing
Open

aas008 wants to merge 1 commit into
openshift-psap:mainfrom
aas008:fix/b200-grafana-dashboard-routing

Conversation

@aas008

@aas008 aas008 commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Updates GRAFANA_DASHBOARDS["B200"] to point to b200-pirate-vllm-dcgm instead of the old psap-b200-mlperf dashboard (cluster no longer exists)
  • Removes dead B200_PIRATE entry — no CSV row ever has accelerator=B200_PIRATE since Forge produces accelerator=B200 via gpu_type.upper()

Context

All 4042 B200 runs in the CSV have accelerator=B200. The routing was pointing to the old psap-b200-mlperf Grafana dashboard which has no metrics. The correct dashboard is b200-pirate-vllm-dcgm.

Test plan

  • Verify B200 runs on staging dashboard link to the correct Grafana dashboard
  • Confirm existing B200 run Grafana links open b200-pirate-vllm-dcgm

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • B200 runs now link to the pirate Grafana dashboard instead of the MLPerf dashboard.

The old psap-b200-mlperf cluster no longer exists. All B200 runs
(accelerator=B200 in CSV) should route to the b200-pirate-vllm-dcgm
dashboard. Also removes dead B200_PIRATE entry since no CSV row
ever has accelerator=B200_PIRATE.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 75a78df6-29e2-44e9-8684-2078321859ac

📥 Commits

Reviewing files that changed from the base of the PR and between ef4aa24 and 9c8d2b5.

📒 Files selected for processing (1)
  • dashboard.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The B200 Grafana dashboard mapping now points to the pirate dashboard. The separate B200_PIRATE mapping is removed.

Changes

B200 Grafana Dashboard

Layer / File(s) Summary
Update B200 dashboard mapping
dashboard.py
The B200 mapping now uses the pirate dashboard identifiers. The separate B200_PIRATE entry is removed.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: harshith-umesh

Merge Risk: ⚪ Minimal · up to 9c8d2

B200 links now target the pirate Grafana dashboard. No broken-link or metrics regression is established; staging checks remain outstanding but do not indicate a merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: routing B200 Grafana links to the pirate cluster dashboard.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@ef4aa24). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff           @@
##             main    #102   +/-   ##
======================================
  Coverage        ?   3.48%           
======================================
  Files           ?       8           
  Lines           ?    8329           
  Branches        ?       0           
======================================
  Hits            ?     290           
  Misses          ?    8039           
  Partials        ?       0           
Flag Coverage Δ
unittests 3.48% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Harshith-umesh

Copy link
Copy Markdown
Member

we will still need the old mlperf grafana dashboard, since 3.4-gA runs were done on that cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants