Skip to content

[release-4.21] OCPBUGS-90498: Projects cannot be filtered by display name in the console list view#16653

Open
cajieh wants to merge 1 commit into
openshift:release-4.21from
cajieh:release-4.21-unable-filter-projects-by-displayname
Open

[release-4.21] OCPBUGS-90498: Projects cannot be filtered by display name in the console list view#16653
cajieh wants to merge 1 commit into
openshift:release-4.21from
cajieh:release-4.21-unable-filter-projects-by-displayname

Conversation

@cajieh

@cajieh cajieh commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • Filter projects by display name in the Projects list
  • Verify fuzzy matching works for display names
  • Verify exact matching works when enabled

🤖 Generated with Claude Code

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 18, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@cajieh: This pull request references Jira Issue OCPBUGS-88739, which is invalid:

  • expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "5.0.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-88739 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Test plan

  • Filter projects by display name in the Projects list
  • Verify fuzzy matching works for display names
  • Verify exact matching works when enabled

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 43b41e85-9311-4f5d-ab00-cef41a8c8760

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from Leo6Leo and rhamilto June 18, 2026 18:11
@openshift-ci

openshift-ci Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cajieh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 18, 2026
@cajieh cajieh changed the title OCPBUGS-88739: Filter projects by display name in ConsoleDataView [release-4.22] OCPBUGS-88739: Projects cannot be filtered by display name Jun 18, 2026
@cajieh cajieh changed the title [release-4.22] OCPBUGS-88739: Projects cannot be filtered by display name [release-4.21] - Projects cannot be filtered by display name in the console list view Jun 18, 2026
@openshift-ci-robot openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 18, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@cajieh: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Summary

Test plan

  • Filter projects by display name in the Projects list
  • Verify fuzzy matching works for display names
  • Verify exact matching works when enabled

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cajieh

cajieh commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@cajieh: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cajieh cajieh force-pushed the release-4.21-unable-filter-projects-by-displayname branch from 6ed955b to 7bb0d65 Compare June 18, 2026 18:31
@cajieh cajieh changed the title [release-4.21] - Projects cannot be filtered by display name in the console list view [release-4.21] OCPBUGS-90498: Projects cannot be filtered by display name in the console list view Jun 18, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 18, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@cajieh: This pull request references Jira Issue OCPBUGS-90498, which is invalid:

  • expected Jira Issue OCPBUGS-90498 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Test plan

  • Filter projects by display name in the Projects list
  • Verify fuzzy matching works for display names
  • Verify exact matching works when enabled

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cajieh

cajieh commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@cajieh: This pull request references Jira Issue OCPBUGS-90498, which is invalid:

  • expected Jira Issue OCPBUGS-90498 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cajieh cajieh force-pushed the release-4.21-unable-filter-projects-by-displayname branch from 7bb0d65 to 00d5d72 Compare June 18, 2026 18:37
@cajieh cajieh force-pushed the release-4.21-unable-filter-projects-by-displayname branch from 00d5d72 to 9fb0da0 Compare June 18, 2026 18:44
@cajieh

cajieh commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Note:

Unit tests were excluded from this backport because @testing-library/react v12 in release-4.21 does not export renderHook (added in v13.1.0). Adding test dependencies to a maintenance branch introduces unnecessary risk.

The functional code change is minimal (9 lines) and is covered by:

Follow-up: Consider adding unit tests to release-4.21 when @testing-library/react is upgraded to v13+, or by rewriting tests using the render wrapper pattern compatible with v12.

@rhamilto

Copy link
Copy Markdown
Member

@cajieh, the unit test is not included here, but the description mentions it.

@cajieh

cajieh commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

@cajieh, the unit test is not included here, but the description mentions it.

Updated.

@cajieh

cajieh commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console

@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@cajieh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot

Copy link
Copy Markdown
Contributor

Fix included in release 5.0.0-0.nightly-2026-06-19-082213

@cajieh

cajieh commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

/verified by CI
/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 19, 2026
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 19, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@cajieh: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/core Related to console core functionality jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants