Skip to content

[release-4.22] OCPBUGS-119976: fix(cpo): include unavailable components in KASLoadBalancerNotReachable message - #9502

Open
redhat-chai-bot wants to merge 1 commit into
openshift:release-4.22from
redhat-chai-bot:cherry-pick-9232-to-release-4.22
Open

[release-4.22] OCPBUGS-119976: fix(cpo): include unavailable components in KASLoadBalancerNotReachable message#9502
redhat-chai-bot wants to merge 1 commit into
openshift:release-4.22from
redhat-chai-bot:cherry-pick-9232-to-release-4.22

Conversation

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

This is a manual cherry-pick of #9232 to release-4.22.

The cherry-pick bot failed to create this backport automatically. Conflicts were resolved while preserving the intent of the fix.

Changes

  • Ensures controlPlaneComponentsAvailable is queried when healthCheckErr != nil (not only when the HCP was not previously available)
  • Appends component unavailability details to the health check error message so operators see the full picture when diagnosing KASLoadBalancerNotReachable conditions

Fixes https://redhat.atlassian.net/browse/OCPBUGS-119976


AI-generated. Review for accuracy.

@georgelipceanu requested in Slack thread

…le message

When a KAS health check error occurs simultaneously with unavailable
components, the component information was silently dropped due to
switch-case priority. Append the component unavailability message to
the health check error so operators see the full picture.

Additionally, query controlPlaneComponentsAvailable when healthCheckErr
is non-nil even if the HCP was previously Available. The alreadyAvailable
short-circuit skipped this call, so for a previously-Available HCP the
component names were never populated in the error message.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 3, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-119976, which is invalid:

  • expected the bug to target either version "4.22.0." or "openshift-4.22.0.", but it targets "4.23.0" instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual cherry-pick of #9232 to release-4.22.

The cherry-pick bot failed to create this backport automatically. Conflicts were resolved while preserving the intent of the fix.

Changes

  • Ensures controlPlaneComponentsAvailable is queried when healthCheckErr != nil (not only when the HCP was not previously available)
  • Appends component unavailability details to the health check error message so operators see the full picture when diagnosing KASLoadBalancerNotReachable conditions

Fixes https://redhat.atlassian.net/browse/OCPBUGS-119976


AI-generated. Review for accuracy.

@georgelipceanu requested in Slack thread

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Team

Run ID: ada2769d-c5f3-4c69-98d8-69162c06fbaa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from enxebre and jparrill September 3, 2026 11:39
@openshift-ci openshift-ci Bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Sep 3, 2026
@openshift-ci

openshift-ci Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign cblecker for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.72%. Comparing base (3004374) to head (7ccc0df).

Additional details and impacted files
@@              Coverage Diff              @@
##           release-4.22    #9502   +/-   ##
=============================================
  Coverage         36.71%   36.72%           
=============================================
  Files               777      777           
  Lines             95484    95487    +3     
=============================================
+ Hits              35061    35064    +3     
  Misses            57580    57580           
  Partials           2843     2843           
Files with missing lines Coverage Δ
...ostedcontrolplane/hostedcontrolplane_controller.go 36.41% <100.00%> (+0.07%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants