WINC-1971: Add standalone OTE proxy suite job for vsphere

[rrasouli]

Summary

Adds a standalone vsphere-proxy-e2e-ote Prow job that runs OTE proxy tests on a vsphere proxy cluster.

Changes

• Added new vsphere-proxy-e2e-ote job with OTE dependencies and env (EXTENSION_IMAGE, EXTENSION_BINARY_PATH, EXTENSION_COMPONENT_NAME, TEST_SUITE)
• Uses openshift-tests-extension-setup-out-of-payload and openshift-e2e-test step refs
• Set TEST_SUITE to windows-machine-config-operator/proxy which runs only [node-proxy] tagged tests
• Reuses ipi-vsphere-ovn-hybrid-custom-vxlan-port-proxy workflow for the proxy cluster setup
• Removed ote| from skip_if_only_changed so OTE changes trigger this job

Notes

• The existing vsphere-proxy-e2e-operator job is unchanged
• Separated into its own job per reviewer feedback to keep complexity isolated
• The proxy suite is defined in the companion WMCO PR (chore(deps): update windows-machine-config-operator-release-5-0 to 065dfa1 windows-machine-config-operator#4458)
• No new step-registry components, reuses existing refs
• The two PRs can merge independently -- proxy OTE tests skip on non-proxy clusters until both land

Summary by CodeRabbit

• Adds the standalone vsphere-proxy-e2e-ote Prow job for the Windows Machine Config Operator repository.
• Configures OTE dependencies, environment variables, setup steps, and the windows-machine-config-operator/proxy test suite.
• Reuses the existing proxy-cluster workflow and runs for ote-only changes.
• Leaves vsphere-proxy-e2e-operator unchanged.

[openshift-ci-robot]

@rrasouli: This pull request references WINC-1971 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

The vsphere-proxy-e2e-operator Prow job only ran WMCO e2e tests. This adds OTE steps using the same 3-step pattern as aws-e2e-ote, running the proxy suite after the existing WMCO e2e step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 8ca99942-7664-4322-beb7-875d67d8de10

📥 Commits

Reviewing files that changed from the base of the PR and between 61c3085 and d8df426.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

• ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml

---

Walkthrough

The CI configuration adds an optional vsphere-proxy-e2e-ote job. The job runs WMCO extension tests, monitors the proxy test suite, performs setup-out-of-payload, and runs OpenShift end-to-end tests. Its skip pattern permits ote-only changes.

Changes

WMCO CI job configuration

Layer / File(s)	Summary
Configure vSphere proxy OTE job ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml	Adds the optional vsphere-proxy-e2e-ote job with WMCO test-extension, proxy monitoring, setup-out-of-payload, and OpenShift end-to-end test steps.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: ⚪ Minimal · up to d8df4

This change adds a dedicated vsphere proxy end-to-end CI job and updates its trigger configuration; no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

• openshift/release#83254: Adds a similar optional OpenShift Test Extension CI job for a different operator and workflow.

Suggested reviewers: wgahnagl, mansikulkarni96

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes adding a standalone OTE proxy suite job for vSphere, which is the main change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The commit adds only static YAML/Prow job metadata; diff searches found no Ginkgo title constructs or dynamic test-title values. Job and suite names are fixed strings.
Test Structure And Quality	✅ Passed	The PR changes only CI YAML files; the verified diff contains no Ginkgo test source or test assertions to assess against these requirements.
Microshift Test Compatibility	✅ Passed	The commit adds only Prow YAML configuration and generated presubmit entries; it adds no Ginkgo e2e tests or new MicroShift API usage.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The diff adds only Prow YAML configuration and generated presubmit metadata; it adds no Ginkgo e2e tests or multi-node test assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff only adds CI job configuration and generated Prow presubmit YAML; it introduces no deployment, operator, controller, or topology-dependent scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The HEAD diff changes only two YAML CI files; it adds no OTE process code or stdout writes and reuses existing OTE setup and test steps.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only two YAML CI declarations. No new Ginkgo tests, IPv4 assumptions, or external-connectivity operations appear in the diff.
No-Weak-Crypto	✅ Passed	The pull request adds only a Prow job configuration and references existing test steps; no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret comparison is introduced.
Container-Privileges	✅ Passed	Added job/config lines contain none of the listed privilege settings; the only privileged token is the unchanged pre-existing namespace label at line 305.
No-Sensitive-Data-In-Logs	✅ Passed	The diff adds OTE job settings and standard CI secret mounts, but no logging commands, secret values, tokens, passwords, or PII that could be exposed in logs.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[jrvaldes]

@rrasouli thanks for working on this.

I recommend to create a separated job for the proxy test, or include it in the current e2e-aws job existing for ote.

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml`:
- Around line 397-401: Align the skip patterns for the
windows-machine-config-operator-test image build and the vsphere-proxy-e2e-ote
job so OTE changes trigger both consistently. Update the relevant
skip_if_only_changed configuration to remove or add the ote path as appropriate,
then run make update to regenerate the Prow jobs and ensure the generated master
presubmit includes vsphere-proxy-e2e-ote.

Apply the same fix in
`@ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml`
around lines 394 - 395.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: adcd4c3d-3e82-4ede-b704-c62b7833f3d3

📥 Commits

Reviewing files that changed from the base of the PR and between 61c3085 and cb76859.

📒 Files selected for processing (2)

• ci-operator/config/openshift/windows-machine-config-operator/openshift-windows-machine-config-operator-master.yaml
• clusters/app.ci/publicize/_config.yaml

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rrasouli
Once this PR has been reviewed and has the lgtm label, please ask for approval from jrvaldes. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/windows-machine-config-operator/OWNERS
• ci-operator/jobs/openshift/windows-machine-config-operator/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[rrasouli]

/assign @jrvaldes

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@rrasouli: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-windows-machine-config-operator-master-vsphere-proxy-e2e-ote	openshift/windows-machine-config-operator	presubmit	Presubmit changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[rrasouli]

/test config

[openshift-ci]

@rrasouli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/config	03c7cd5	link	true	/test config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.