modemmanager: fix custom initial EPS bearer username - #30543
Merged
Merged
Conversation
micpf
force-pushed
the
fix/modemmanager-init-username
branch
from
September 16, 2026 11:48
2de5eec to
a7330e5
Compare
openwrt-ai
reviewed
Sep 17, 2026
The custom initial EPS bearer code uses init_username, which agrees with the documented UCI option. However, the option was registered and read as init_user, so init_username was discarded before the custom EPS bearer settings were passed to mmcli. Register and read the option consistently as init_username. Signed-off-by: Michael Pfeifroth <micpf@westermo.com>
micpf
force-pushed
the
fix/modemmanager-init-username
branch
from
September 17, 2026 07:53
a7330e5 to
be28dc1
Compare
Member
|
Thanks merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom initial EPS bearer code uses
init_username, matching the documented UCI option, but the option is registered and loaded asinit_user. As a result, the configured username is silently omitted from the initial EPS bearer settings passed to mmcli.Register and load the option consistently as
init_username.Signed-off-by: Michael Pfeifroth micpf@westermo.com