Conversation
openwrt-ai
reviewed
Sep 17, 2026
1 task done
openwrt-ai
reviewed
Sep 18, 2026
Expose squeezelite's ALSA-control volume mode through UCI: mixer (-V control name), mixer_device (-O ctl device) and linear_volume (-X). Without a mixer the existing unmute (-U) path is unchanged; the two are mutually exclusive in squeezelite, so unmute is listed in the default config next to mixer to make that visible. Signed-off-by: Kel Modderman <kelvmod@gmail.com>
The command line was built as a flat string and expanded unquoted into procd_set_param, so any value containing a space (ALSA control names like "PCM Playback Volume", player names like "Living Room") was split into several arguments. Append each option via procd_append_param instead; the string is only kept for the logger line. The -r and -e flags are passed explicitly rather than folded into their values. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Kel Modderman <kelvmod@gmail.com>
kel-mo
force-pushed
the
squeezelite-mixer
branch
from
September 18, 2026 06:25
5b9b2d7 to
df209b5
Compare
openwrt-ai
reviewed
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @thess
Description:
Expose squeezelite's ALSA-control volume mode through UCI: mixer (-V control name), mixer_device (-O ctl device) and linear_volume (-X). Without a mixer the existing unmute (-U) path is unchanged; the two are mutually exclusive in squeezelite.
🧪 Run Testing Details
Run tested: playback works as expected via MA on gl-mt2500a SNAPSHOT
✅ Formalities