graft: add new package - #30553
graft: add new package#30553techievena wants to merge 1 commit into
Conversation
Local-first composition workspace. Incremental compiler for video. Runtime ffmpeg via shell-out; rust/host for the build. https://github.com/eonik-ai/graft/releases/tag/v0.2.2 Signed-off-by: Abinash Senapati <abinashsena@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
BKPepe
left a comment
There was a problem hiding this comment.
What is the concrete use case for running graft on an OpenWrt router?
From the description, this is a local-first video composition/incremental compiler, with ffmpeg as a runtime dependency. Could you explain what OpenWrt-specific use case this addresses and why this belongs in the OpenWrt package feed rather than being something users build/install separately when they need it?
In particular, who are the intended OpenWrt users of this package and what would they use it for on a router?
| PKG_BUILD_PARALLEL:=1 | ||
|
|
||
| include $(INCLUDE_DIR)/package.mk | ||
| include ../../lang/rust/rust-package.mk |
There was a problem hiding this comment.
The build fails on all 10 target arches because the tarball root is a cargo workspace, and Build/Compile/Cargo runs cargo install --path $(PKG_BUILD_DIR)/$(MAKE_PATH) with the default MAKE_PATH ?= .:
cargo install -v --profile release --root .../ipkg-install --path ".../graft-0.2.2/." --locked
error: found a virtual manifest at `/builder/build_dir/target-riscv64_generic_musl/graft-0.2.2/Cargo.toml` instead of a package manifest
make[2]: *** [Makefile:44: .../graft-0.2.2/.built] Error 101
Set MAKE_PATH to the subdirectory holding the graft binary crate's Cargo.toml (e.g. MAKE_PATH:=crates/graft) so cargo gets a package manifest rather than the workspace root.
Generated by Claude Code
| define Package/graft | ||
| SECTION:=utils | ||
| CATEGORY:=Utilities | ||
| TITLE:=Change the hook. Keep the body |
There was a problem hiding this comment.
TITLE is the one-line label shown in menuconfig and in the package index, so it has to say what the package is; a tagline leaves users with no idea what graft does. Every neighbouring rust package uses a descriptive phrase (e.g. TITLE:=A modern, maintained replacement for ls in utils/eza/Makefile).
| TITLE:=Change the hook. Keep the body | |
| TITLE:=Local-first video composition workspace |
Generated by Claude Code
Local-first composition workspace. Incremental compiler for video.
Runtime ffmpeg via shell-out; rust/host for the build.
https://github.com/eonik-ai/graft/releases/tag/v0.2.2
This replaces #30552. FormalityCheck audits every commit; the first
commit on that PR lacked Signed-off-by. This PR is a single commit
with DCO and a two-space description indent.
Signed-off-by: Abinash Senapati abinashsena@gmail.com
Made with Cursor