Skip to content

graft: add new package - #30553

Open
techievena wants to merge 1 commit into
openwrt:masterfrom
techievena:graft-0.2.2-signed
Open

techievena wants to merge 1 commit into
openwrt:masterfrom
techievena:graft-0.2.2-signed

Conversation

@techievena

Copy link
Copy Markdown

Local-first composition workspace. Incremental compiler for video.
Runtime ffmpeg via shell-out; rust/host for the build.

https://github.com/eonik-ai/graft/releases/tag/v0.2.2

This replaces #30552. FormalityCheck audits every commit; the first
commit on that PR lacked Signed-off-by. This PR is a single commit
with DCO and a two-space description indent.

Signed-off-by: Abinash Senapati abinashsena@gmail.com

Made with Cursor

Local-first composition workspace. Incremental compiler for video.
Runtime ffmpeg via shell-out; rust/host for the build.

https://github.com/eonik-ai/graft/releases/tag/v0.2.2

Signed-off-by: Abinash Senapati <abinashsena@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

@BKPepe BKPepe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the concrete use case for running graft on an OpenWrt router?

From the description, this is a local-first video composition/incremental compiler, with ffmpeg as a runtime dependency. Could you explain what OpenWrt-specific use case this addresses and why this belongs in the OpenWrt package feed rather than being something users build/install separately when they need it?

In particular, who are the intended OpenWrt users of this package and what would they use it for on a router?

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 commit.


Generated by Claude Code

Comment thread utils/graft/Makefile
PKG_BUILD_PARALLEL:=1

include $(INCLUDE_DIR)/package.mk
include ../../lang/rust/rust-package.mk

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build fails on all 10 target arches because the tarball root is a cargo workspace, and Build/Compile/Cargo runs cargo install --path $(PKG_BUILD_DIR)/$(MAKE_PATH) with the default MAKE_PATH ?= .:

cargo install -v --profile release --root .../ipkg-install --path ".../graft-0.2.2/." --locked
error: found a virtual manifest at `/builder/build_dir/target-riscv64_generic_musl/graft-0.2.2/Cargo.toml` instead of a package manifest
make[2]: *** [Makefile:44: .../graft-0.2.2/.built] Error 101

Set MAKE_PATH to the subdirectory holding the graft binary crate's Cargo.toml (e.g. MAKE_PATH:=crates/graft) so cargo gets a package manifest rather than the workspace root.


Generated by Claude Code

Comment thread utils/graft/Makefile
define Package/graft
SECTION:=utils
CATEGORY:=Utilities
TITLE:=Change the hook. Keep the body

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TITLE is the one-line label shown in menuconfig and in the package index, so it has to say what the package is; a tagline leaves users with no idea what graft does. Every neighbouring rust package uses a descriptive phrase (e.g. TITLE:=A modern, maintained replacement for ls in utils/eza/Makefile).

Suggested change
TITLE:=Change the hook. Keep the body
TITLE:=Local-first video composition workspace

Generated by Claude Code

@BKPepe BKPepe added the stale label Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants