Conversation
…erage executable Two workflow defects hit every pull request. The benchmark comparison step runs under `bash -e`, so a non-zero exit from `benchmark baseline check` aborted the step before the exit-code mapping and every threshold deviation reported as an unknown failure; the workflow has failed on all eight runs in its history. With the mapping reachable, a crash or a missing baseline also needs a comment producer, so the failure text now covers every status that is not same, regression or improvement. The coverage export looked for `<repository>PackageTests.xctest`, but the package is named FixedPointDecimal, and since the `swift:latest` container moved to 6.4 the default Swift Build backend emits per-target runner and `.so` artifacts, so the fallback `find` came back empty and `llvm-cov` ran with no file. The coverage run now uses the native build system, whose single `<Package>PackageTests.xctest` executable the export step finds by package name, and the step lists the build directory when it finds nothing instead of invoking `llvm-cov` without a file. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
+ Coverage 96.79% 96.83% +0.04%
==========================================
Files 35 35
Lines 4795 4795
==========================================
+ Hits 4641 4643 +2
+ Misses 154 152 -2 see 2 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
Pull request had a regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two workflows fail on every pull request in this repository, independent of the change under review; #8 shows both.
Benchmark comparison always reports an unknown failure. The compare step in
swift-benchmark-delta.ymlruns under GitHub's defaultbash -e.swift package benchmark baseline checkexits non-zero for any threshold deviation, so the step aborted at that line, before the stderr mapping that turns the result into same, improvement, regression, crash or missing baseline.exitStatuskept its initial value of 1 and the job failed with "unknown failure" whatever the benchmark actually said; the workflow has never passed in its eight-run history. Aset +e/set -eguard around the check lets the mapping run. With the mapping reachable, a crash or a missing baseline now also gets a comment producer: the failure text step covers every status other than same, regression and improvement, with distinct wording for those two.Coverage export finds no executable.
swift-code-coverage.ymllooked for.build/debug/<repository name>PackageTests.xctest, but the package is named FixedPointDecimal, so that path never existed and the job relied on a recursivefindfor any.xctestfile. That worked until theswift:latestcontainer moved to Swift 6.4, whose default Swift Build backend emits per-target-test-runnerand.soartifacts on Linux and no.xctestat all. Thefindcame back empty, and because the file test was unquoted,[ -f ]evaluated true andllvm-cov exportran without a file ("No filenames specified!"). The coverage run now uses--build-system native(supported, deprecated in 6.4), which keeps the single<Package>PackageTests.xctestexecutable, and the export step finds it by package name, keeps the recursive fallback, quotes the path, and lists the build directory before failing if nothing is found.Verification. Shell control flow of both steps checked by hand against the follow-up steps; SwiftPM's behaviour for
--build-system nativeand the profile path taken from the 6.4.0 release sources. No Linux Swift 6.4 build was run locally (no container runtime on the machine), so this PR's own CI run is the first real test of the coverage path. Codex (gpt-6-astra) blocked the first version of the coverage fix, which assumed a.swift-testingexecutable that Swift Build never produces; the rework above answers that and its two should-fix points, and its final pass found nothing blocking.🤖 Generated with Claude Code