convert_waveform_coordinates: apply source_redshift to input masses (mu1/mu2 frame) - #207
Closed
oshaughnessy-junior wants to merge 1 commit into
Conversation
…input masses With source_redshift=z, the vectorized branches computed mu1/mu2 from the source-frame mc. On rift_O4c the final rescale also scaled a ROW instead of a column (fixed on rift_O4d by da75550). Now the low-level mass inputs (mc, mc_ecc, m1, m2, mtot) are multiplied by 1+z once, on a copy, at entry. The per-row fallback rescales P.m1, P.m2 only when no input was rescaled. Test: vectorized output vs the per-row extract_param path at z=0 and 0.3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
oshaughnessy-junior
deployed
to
private-review-dispatch-rift-upstream
October 4, 2026 23:59 — with 
GitHub Actions
Active
GitHub Actions
Active
oshaughnessy-junior
marked this pull request as ready for review
October 5, 2026 00:03
oshaughnessy-junior
deployed
to
private-review-dispatch-rift-upstream
October 5, 2026 00:03 — with
GitHub Actions
Active
GitHub Actions
Active
Contributor
Author
|
Wrong target: O4d changes go into oshaughnessy-junior/rift_O4d. Replaced by oshaughnessy-junior#397, rebuilt on junior/rift_O4d. |
oshaughnessy-junior
deployed
to
private-review-dispatch-rift-upstream
October 5, 2026 01:32 — with
GitHub Actions
Active
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
source_redshift=z, the vectorizedmu1/mu2blocks inconvert_waveform_coordinatesused the source-framemc. At z=0.3 they disagree with the per-rowextract_parampath. Themc/m1/m2column rescale (da75550) was already correct.Fix: multiply the low-level mass inputs (
mc,mc_ecc,m1,m2,mtot) by 1+z once, on a copy, at entry, and drop the end-of-function rescale. The per-row fallback rescalesP.m1,P.m2only when no input was rescaled. The caller's array is unchanged.Test:
test_convert_coordinates_source_redshift.py, added to core-units (floors 393/381). On ldas-grid (CVMFS igwn python, no cupy), it passes 13/13 here and fails the 4mucases on base f50713b. On CIT, core-units has 1 failure,test_portfolio_balance_heuristic. It fails 3 of 3 runs on the base as well. An adversarial review found no defects.The O4c fix rides in #204.
🤖 Generated with Claude Code