Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pick with one choice left still goes out as a choice question with one option. Clef and vLLM-SR need at least two options, so the step fails. A domain like the triage example in the README gets there once every log is read and only stop is left. I ran that on vLLM-SR and it ended with
422 question_failedon d3-ultra and400 invalid_requeston d3-flash.rubric-judge already skips the request when only stop is left (
onlyStop). This does the same in the loop for any domain: a choice with one option gets that option as its answer, and no request goes out for it.