Skip to content

🐛 Fix #236: stop forwarding backoff_jitter to requests#238

Open
YashGaykar0309 wants to merge 2 commits into
mainfrom
fix/issue-236-backoff-jitter
Open

🐛 Fix #236: stop forwarding backoff_jitter to requests#238
YashGaykar0309 wants to merge 2 commits into
mainfrom
fix/issue-236-backoff-jitter

Conversation

@YashGaykar0309

@YashGaykar0309 YashGaykar0309 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Description

  • Fixes compatibility with urllib3 1.26.x, which is required by some boto3/botocore versions.
  • Retry options (max_retries, backoff_factor, backoff_jitter, and backoff_max) are now handled entirely by the SDK retry logic and are no longer forwarded to requests, preventing unexpected keyword argument errors.
  • Custom retry settings are preserved across retry attempts by restoring them when creating subsequent Retry instances.
  • The minimum urllib3 requirement is relaxed from >=2.6.3 to >=1.26.0.

Fixes: #236

Please check the relevant option(s):

  • 🐛 Bug fix
  • ✨ New feature
  • 🧹 Code cleanup or refactor
  • 📝 Documentation update
  • 🔧 Build or CI-related change
  • 🔒 Security fix
  • Other (specify):

How Has This Been Tested?

Please describe the test strategy:

  • Manual testing
  • Unit tests
  • Integration tests
  • Not tested yet

Commands used (if applicable):

# Example
my-cli-tool build --verbose
my-cli-tool test

Checklist

  • I have followed the Contributing Guidelines
  • I have added tests or explained why they are not needed
  • I have updated relevant documentation (README, examples, etc.)
  • My changes follow the Conventional Commits specification
  • My commits include appropriate Gitmoji

@YashGaykar0309 YashGaykar0309 requested a review from a team July 3, 2026 07:26
@YashGaykar0309 YashGaykar0309 changed the title 🐛 fix: strip retry options before sending requests 🐛 Fix #236: stop forwarding backoff_jitter to requests Jul 3, 2026
outscale-rce
outscale-rce previously approved these changes Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Since version >= 0.38 using instanciated Gateway fails because of introduction of backoff algorithm

2 participants