Repository navigation
handles precondition failed from the adapter errors - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conformance tests check the HAL wire contract, not adapter functionality. FAILED_PRECONDITION could be returned by the adapter because of its own state and precondition checks; We treat FAILED_PRECONDITION as a contract , and if is returned by an adapter, we skip the particular test for that adapter (involving checking the response format as there is no response sent in these cases), so other third-party adapters with different sequences still pass.
Adapters can either return FAILED_PRECONDITION or return a valid response incase of a precondition failing. Both cases will be handled by the tests.
The adpater provider can chose the approach, depending on the level of observability the particular adapter wants to provide to the caller/controller.
Pins versions in Makefile and proto-ci.yaml so
make generatechanges from local match the ones in CI for the CI checks to pass.Conformance Test Results