Skip to content

fix searching stickers from my sets by emoji - #1249

Open
kambala-decapitator wants to merge 7436 commits into
overtake:masterfrom
kambala-decapitator:patch-2
Open

kambala-decapitator wants to merge 7436 commits into
overtake:masterfrom
kambala-decapitator:patch-2

Conversation

@kambala-decapitator

Copy link
Copy Markdown

took the solution from the iOS client, tested locally successfully

fixes #1196

Mikhail Filimonov added 15 commits July 22, 2025 12:15
…release' of gitlab.com:overtake/telegrammacos into release

# Conflicts:
#	Telegram-Mac/ApplicationContext.swift
#	Telegram-Mac/Info.plist
#	Telegram-Mac/PeerMediaGiftsController.swift
#	Telegram.xcodeproj/project.pbxproj
#	TelegramShare/Info.plist
#	submodules/telegram-ios
@CLAassistant

ghost commented Aug 14, 2025

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kambala-decapitator
❌ overtake
You have signed the CLA already but the status is still pending? Let us recheck it.

@ForsakenHarmony

ghost commented Nov 19, 2025

Copy link
Copy Markdown

@overtake you need to stop force pushing to master lol

@bearz314

ghost commented Apr 4, 2026

Copy link
Copy Markdown

Hi @kambala-decapitator, thanks for your work on this!

Did you see the review message? It appears to be waiting for Contributor License Agreement to be signed. If you click on the ellipses, and then More Details, it can be signed with a GitHub account.

Thanks!

@kambala-decapitator

ghost commented Apr 4, 2026

Copy link
Copy Markdown
Author

Hi @kambala-decapitator, thanks for your work on this!

Did you see the review message? It appears to be waiting for Contributor License Agreement to be signed. If you click on the ellipses, and then More Details, it can be signed with a GitHub account.

Thanks!

don't you see there's a green checkmark near my name meaning that I've already signed it?

@bearz314

ghost commented Apr 4, 2026

Copy link
Copy Markdown

Hi @kambala-decapitator, thanks for your work on this!
Did you see the review message? It appears to be waiting for Contributor License Agreement to be signed. If you click on the ellipses, and then More Details, it can be signed with a GitHub account.
Thanks!

don't you see there's a green checkmark near my name meaning that I've already signed it?

Ah my apologies and thank you for pointing that out! Gotta wait for @overtake then.

@kambala-decapitator

ghost commented Apr 4, 2026

Copy link
Copy Markdown
Author

Gotta wait for @overtake then.

good luck xDDDD

@purrloftruth

ghost commented May 27, 2026

Copy link
Copy Markdown

@bearz314, I think there was some kind of miscommunication here. This repository belongs to @overtake in the first place; there is absolutely no reason they should not have already signed a CLA. It also looks like many (if not all) of overtake's commits added to this PR are completely unrelated to what this PR is meant to fix. Neither of the two actual changes to code that this PR makes were authored by overtake. Is there any chance that this can be looked at and potentially have those commits removed from this PR? This bug has been present since 2024 and is the sole reason I switched away from Telegram for macOS to TDesktop. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MacOs Telegram Desktop: search sticker by emoji not working in latest version

8 participants