Skip to content

ci: [k6-test] [OCISDEV-900] Extract upload coordinator out of decomposedfs - #12913

Merged
f-firas merged 3 commits into
masterfrom
chore/OCISDEV-900-reva-bump
Oct 7, 2026
Merged

f-firas merged 3 commits into
masterfrom
chore/OCISDEV-900-reva-bump

Conversation

@LarsJurgensen

@LarsJurgensen LarsJurgensen commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Description

Bumps reva to pick up the upload coordinator refactor (OCISDEV-900) and wires two config keys that the new coordinator requires.

Config changes (ocis side):

  • storage-users dataprovider: adds mount_id so the coordinator can tag upload sessions with the correct mount.
  • ocm dataprovider + storageprovider: adds upload_directory pointing at <storage_root>/uploads/. The coordinator needs an explicit upload directory for drivers that have no implicit filesystem root.

No behavioural changes in oCIS itself. The upload state machine now lives in reva's pkg/upload coordinator; see the reva changelog below for the full picture.

Reva changelog summary (from reva, included for context):

The TUS session lifecycle, postprocessing event loop, AV integration, and restart safety have been extracted from decomposedfs into a driver-agnostic coordinator in pkg/upload. Drivers implement four new methods: MarkProcessing, PrepareUpload, CommitUpload, and RollbackUpload. Existing in-flight uploads continue without interruption, because session files stay at the same on-disk path.

Related Issue

Motivation and Context

Decomposedfs was the only driver that could do TUS chunked uploads, postprocessing, and AV scanning because all that logic was embedded inside it. Extracting it into a coordinator means future drivers (KW, OCM, etc.) inherit it for free.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised: —

@LarsJurgensen
LarsJurgensen requested a review from a team as a code owner September 9, 2026 14:50
@update-docs

update-docs Bot commented Sep 9, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kw-security

kw-security commented Sep 9, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@f-firas
f-firas force-pushed the chore/OCISDEV-900-reva-bump branch from a95ced1 to e505ae9 Compare October 7, 2026 07:46
f-firas
f-firas previously approved these changes Oct 7, 2026
@f-firas
f-firas merged commit cc8c1c8 into master Oct 7, 2026
24 of 38 checks passed
@f-firas
f-firas deleted the chore/OCISDEV-900-reva-bump branch October 7, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants