Repository navigation
ci: [k6-test] [OCISDEV-900] Extract upload coordinator out of decomposedfs - #12913
Merged
Merged
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
LarsJurgensen
force-pushed
the
chore/OCISDEV-900-reva-bump
branch
from
September 16, 2026 13:15
dd15f60 to
c7eb41b
Compare
f-firas
force-pushed
the
chore/OCISDEV-900-reva-bump
branch
from
October 1, 2026 08:31
c612e6b to
c236c12
Compare
… and mount_id to revaconfig
f-firas
force-pushed
the
chore/OCISDEV-900-reva-bump
branch
from
October 7, 2026 07:46
a95ced1 to
e505ae9
Compare
f-firas
previously approved these changes
Oct 7, 2026
f-firas
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps reva to pick up the upload coordinator refactor (OCISDEV-900) and wires two config keys that the new coordinator requires.
Config changes (ocis side):
storage-usersdataprovider: addsmount_idso the coordinator can tag upload sessions with the correct mount.ocmdataprovider + storageprovider: addsupload_directorypointing at<storage_root>/uploads/. The coordinator needs an explicit upload directory for drivers that have no implicit filesystem root.No behavioural changes in oCIS itself. The upload state machine now lives in reva's
pkg/uploadcoordinator; see the reva changelog below for the full picture.Reva changelog summary (from reva, included for context):
The TUS session lifecycle, postprocessing event loop, AV integration, and restart safety have been extracted from decomposedfs into a driver-agnostic coordinator in
pkg/upload. Drivers implement four new methods:MarkProcessing,PrepareUpload,CommitUpload, andRollbackUpload. Existing in-flight uploads continue without interruption, because session files stay at the same on-disk path.Related Issue
Motivation and Context
Decomposedfs was the only driver that could do TUS chunked uploads, postprocessing, and AV scanning because all that logic was embedded inside it. Extracting it into a coordinator means future drivers (KW, OCM, etc.) inherit it for free.
Types of changes
Checklist: