Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
2403905
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cuts down the disk work the upload coordinator does when an upload finishes. Since uploads started going through the coordinator, finishing a new file took four separate writes to the node's metadata plus two saves of the upload session, where the old upload path did one of each. Every write rewrites the whole
.mpk, which is why the seed phase of the load test was noticeably slower than master.PrepareUpload already writes a batch of attributes to the node, so it now also creates the node when it doesn't exist yet, and sets the processing flag in that same batch. That makes the coordinator's separate TouchFile and MarkProcessing calls unnecessary, and the session only needs saving once, after PrepareUpload. The node is created under the id we already mint at initiate, so nothing has to be swapped in afterwards. If PrepareUpload fails, it purges the node it created itself (no Delete permission needed), and the checks that can reject an upload without touching the node, like checksums and request metadata, now run before anything is created.