Mobile layout - #3358
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
Collaborator
Author
Collaborator
Author
|
Responsive crumbs, improve profile button collapse behavior, put username inside mobile version of user menu since it disappears from the button. 2026-09-01-responsive.crumbs.mp4 |
david-crespo
force-pushed
the
mobile-styling-quick-wins
branch
from
September 1, 2026 16:35
bab0393 to
2dcbf89
Compare
david-crespo
force-pushed
the
mobile-styling-quick-wins
branch
from
September 1, 2026 16:55
2dcbf89 to
3b6135a
Compare
Collaborator
Author
|
Looking really solid, only a couple of rough spots, probably mergable as-is. 2026-09-01-full-mobile-demo.mp4Bad button
Can't see disk name in mini-tableThe stacking buttons are a little sad but tolerable. https://console-3o84wwqme-oxidecomputer.vercel.app/projects/mock-project/instances-new
|
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





#3178 was meant to redo part of #2087 as a stepping stone to a proper mobile layout, but then we didn't follow up, which means the mobile layout actually got worse — it's really bad! This is an attempt at some quick fixes to make it tolerable without breaking anything for desktop users. As long as nothing on desktop sizes is affected, even if there are flaws it's hard for it to be worse than the status quo. I think it feels really good, and a thorough review by Fable 5.1 didn't turn up any regressions at desktop sizes.
🤖 Summary
Makes the console usable below 1000px, which is the existing
1000:breakpoint from the design system. Above that width the layout is unchanged apart from the items called out at the end.Navigation
app/stores/mobile-nav.ts) so the top bar and sidebar can share it.PageSkeletonrenders the sidebar closed so there is no flash of an open drawer during load.app/layouts/helpers.tsxare used by bothTopBarandPageSkeletonso the two can't drift.Components
Modal,SideModal,Toast, andErrorPageare capped to the viewport width with a gutter so they no longer run edge to edge or overflow.CardBlock.Headeractions,DisksTableFieldbuttons,Radiocards, andDateTimeRangePickerstack or stretch to full width on small screens.Changes that also affect desktop
--content-guttershrinks below 1000px rather than 768px, so windows between 768 and 999px get the narrower gutter. This aligns the gutter with the layout breakpoint used everywhere else.overscroll-behavior-y: noneonbodyprevents pull-to-refresh and scroll chaining behind the sidebar overlay. On macOS this also removes the vertical rubber-band bounce.DropdownMenu.ContentdefaultscollisionPaddingto 12px (Base UI default is 5px) so menus keep a consistent margin from the viewport edge.Tests
test/e2e/mobile-layout.e2e.tscovers the sidebar overlay open/close/navigate flow, the breakpoint transition at 999/1000px, the username in the user menu, and modal/toast bounds at 320px.test/e2e/breadcrumbs.e2e.tsadds cases for collapsed breadcrumbs at 404, 650, 750, and 1024px, including the full-path menu.getByTextnow also matches the hidden breadcrumb measurement copy.