Do not send progress notifications - #1981
Merged
Merged
Conversation
Sending four progress notification messages per extent is way too many, considering Nexus currently does nothing with this information, and is not planning on doing anything with this information. I briefly considered sending one notification message per extent, but ended up removing progress notification altogether. Nexus still relies on the start and finish messages, so keep those in. "Client stopped" messages are also still sent as those are not too noisy. Fixes oxidecomputer#1979.
leftwo
approved these changes
Sep 29, 2026
leftwo
left a comment
leftwo
left a comment
Contributor
There was a problem hiding this comment.
Maybe someday we will turn the per-extent notifications back on, as I think they would be good to pass on to the end users (so they could see progress). But, until that day, less is more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending four progress notification messages per extent is way too many, considering Nexus currently does nothing with this information, and is not planning on doing anything with this information. I briefly considered sending one notification message per extent, but ended up removing progress notification altogether.
Nexus still relies on the start and finish messages, so keep those in. "Client stopped" messages are also still sent as those are not too noisy.
Fixes #1979.