Repository navigation
Fix 1980, allow more downstairs state transitions - #1984
Merged
Merged
Conversation
When a LiveRepair is in progress and all three downstairs go away, we fall back to reconciliation, even though the upstairs is active. If we then have another failure during the reconciliation, we must allow a downstairs to transition to faulted to then restart the reconciliation. Flagging this state transition as invalid was a bug and this fixes that.
jmpesp
approved these changes
Oct 2, 2026
| // active, put all three into live-repair so that we fall back to | ||
| // reconciliation while the upstairs is active, then abort that | ||
| // reconciliation. The downstairs should restart and come back | ||
| // through live-repair, instead of panicking on an invalid state |
Contributor
There was a problem hiding this comment.
/s/live-repair/reconciliation? also this test doesn't seem to validate this last part (that they enter reconciliation after the abort)
Extend test_downstairs_three_live_repair_failed_reconcile to bring all three downstairs back to LiveRepairReady after the aborted reconciliation, and verify that they all re-enter reconciliation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a LiveRepair is in progress and all three downstairs go away, we fall back to reconciliation, even though the upstairs is active. If we then have another failure during the reconciliation, we must allow a downstairs to transition to faulted to then restart the reconciliation. Flagging this state transition as invalid was a bug and this fixes that.
Fix for #1980