-
Notifications
You must be signed in to change notification settings - Fork 240
transceivers: Implement double-polling for transceiver temperatures #2668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
12f2786
static-cell: Change unsafe Sync impl for ClaimOnceCell
jamesmunns f08e458
Implement double-sampling of transceiver temps
jamesmunns 439e9b0
Make the transceivers server a ClaimOnceCell so we can pull it in dumps
jamesmunns 755934d
Implement metadata and stats
jamesmunns 8618c34
Merge remote-tracking branch 'origin/master' into james/xcvr-doubletap
jamesmunns afaeaa4
Better ringbuf, no Milli-celsius
jamesmunns 3adcb7a
Fix some review comments
jamesmunns d1e0866
Add ringbuf specifically for glitches
jamesmunns 0c080db
Count differently
jamesmunns ff00d97
Address some comments from Aaron
jamesmunns 7b824bd
Sorry, clippy
jamesmunns 8429e28
Merge remote-tracking branch 'origin/master' into james/xcvr-doubletap
jamesmunns 5e7d411
Address review comments
jamesmunns ce3202e
update docs
jamesmunns 781d22b
Merge remote-tracking branch 'origin/master' into james/xcvr-doubletap
jamesmunns e5882f2
Apply batched suggestions from code review
jamesmunns 5a83b80
Address review comments
jamesmunns File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is cute; I wonder if we might want the
counterscrate to have a macro or something for saying "yes, this looks like au32, but it will always be in some range, so you can derive counters for it without having to worry"; elsewhere, I've tended to just userepr(N)enums for this sort of thing, like this thing:hubris/drv/psc-seq-server/src/main.rs
Lines 390 to 403 in 0d1ba04
but that then requires some weirdish boilerplate for converting between the enum and integers if you also want to index arrays or whatever.
very much not a blocker for this PR, but I wonder if we might throw together a little newtype-integer-counter derive or something that works like this.