humility: Begin target addr agnosticism - #733
Open
jamesmunns wants to merge 7 commits into
Open
jamesmunns wants to merge 7 commits into
jamesmunns wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the Minimum Viable Change necessary to make things Just Work with oxidecomputer/hubris#2703.
This does not get us all the way to target-bitwidth agnosticism, but makes humility dumps continue to work both with existing, pre-
Addrchanges, as well as with post-2703 images.It is IMO, somewhat icky to half-land these features, but the "
u32is a (target) address" is pervasive inhumility,humpty, and even inhubrisbeyond what 2703 touches, so I think pragmatically we will want to carefully land these changes incrementally.With a 2703-containing sidecar image, and on ~current humility master:
With ~current
mastersidecar image, and on this branch:With a 2703-containing sidecar image, and on this branch: