[6/n] [reconfigurator] collapse rendezvous_sled_bp_availability write types - #11189
Conversation
Created using spr 1.3.6-beta.1
sunshowers
commented
Aug 27, 2026
Comment on lines
-371
to
-378
| RendezvousSledBpAvailabilityUpdate::new( | ||
| sled_id, | ||
| ps.availability, | ||
| UpdateDispositionGeneration::from( | ||
| ps.generation, | ||
| ), | ||
| blueprint_id, | ||
| ), |
Contributor
Author
There was a problem hiding this comment.
Very sad to lose the better typing here but overall I think this is better.
sunshowers
marked this pull request as draft
August 28, 2026 19:50
Contributor
Author
|
(marking this draft, thinking of a different rework) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My dream was that we'd treat these as completely distinct cases, but that dream is dead in a subsequent commit which seeds these rows from rack initialization in tests.