Allow Nexus to listen on a second address - #11208
Merged
Merged
Conversation
bnaecker
commented
Sep 1, 2026
bnaecker
commented
Collaborator
- Add a second socket address to Nexus's config format. This is optional, for backwards compatibility. If specified, start a second external API server on the second address, sharing the rest of the Dropshot configuration and API context.
- Fixes Nexus needs to support listening on multiple external addresses #11006
- Add a second socket address to Nexus's config format. This is optional, for backwards compatibility. If specified, start a second external API server on the second address, sharing the rest of the Dropshot configuration and API context. - Fixes #11006
jgallagher
reviewed
Sep 2, 2026
- Use a vec of any additional addresses - Store all external servers in a vec
jgallagher
approved these changes
Sep 2, 2026
jgallagher
left a comment
jgallagher
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just a few nits.
davepacheco
reviewed
Sep 2, 2026
davepacheco
left a comment
davepacheco
left a comment
Collaborator
There was a problem hiding this comment.
Sorry this is late, and this isn't a big deal.
Comment on lines
+181
to
+182
| #[schemars(skip)] | ||
| #[serde(default)] |
Collaborator
There was a problem hiding this comment.
I was going to comment here that I think this shouldn't be necessary for backwards compatibility and I thought we generally avoid carrying this baggage (instead opting to update all the in-repo copies of the file, which is all that should matter). But taking a closer look, I think we have done this in a lot of places, for better or worse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.