Repository navigation
Conversation
When the server reset a stream because of a stream error, the handler's request context stayed live, so a handler waiting on it never returned. Only a client RST_STREAM canceled it. Port golang.org/x/net/http2 8aa6dbf4 (CL 585595, golang/go#67036) to http2 and to the bundled server in h2_bundle.go: closeStream cancels the stream's context. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the server resets a stream because of a stream error (for example, a second HEADERS frame on a stream that has already ended), the handler's request context stays live. A handler waiting on
r.Context().Done()never returns. Only an RST_STREAM from the client cancels it today.This ports golang.org/x/net/http2 8aa6dbf4 (CL 585595, golang/go#67036):
closeStreamcancels the stream's context. It is one line inhttp2/server.goand the same line inh2_bundle.go.Tests:
TestServerRequestCancelOnErrorinhttp2is the x/net test.TestBundledServerRequestCancelOnErrordoes the same against the bundled server, using a small raw-frame client (h2_bundle_server_test.go).Without the fix, the x/net test hangs and the bundled one fails after 5s; both pass with it.
go test ./...passes; the new tests also pass with-race.🤖 Generated with Claude Code