Repository navigation
Conversation
An http2.Transport built as a struct literal has no t1, so it ignores the HTTP/1 settings it would otherwise read from it, such as ResponseHeaderTimeout. ConfigureTransports is the only way to set t1, and it also registers the HTTP/2 transport on t1, which callers that dial their own connections, like tls-client, do not want. SetT1 complements GetT1 and lets those callers provide the settings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
http2.Transportbuilt as a struct literal has not1, so it ignores the HTTP/1 settings it would otherwise read fromt1:ResponseHeaderTimeout,DisableKeepAlivesandExpectContinueTimeout.ConfigureTransportsis the only way to sett1, and it also registers the HTTP/2 transport ont1'sTLSNextProto. Callers that dial their own connections, such as tls-client, do not want that.SetT1complementsGetT1. It is documented as setup-only: it must be called before the transport is first used, becauset1is read without locking.tls-client needs it for
TransportOptions.ResponseHeaderTimeout(PR to follow). Itsif t1 := t2.GetT1(); t1 != nilblock inroundtripper.gonever runs today for the same reason.TestTransportResponseHeaderTimeout_*now setst1throughSetT1instead of assigning the unexported field, so they test the new API end to end.go test ./...passes.🤖 Generated with Claude Code