Repository navigation
Conversation
The HTTP/1 request writer replaces a caller's Content-Length, Transfer-Encoding or Trailer under any case with the value from the request, written under the canonical name (bogdanfinn#32). A request whose headers are all lower case, as Node's fetch writes them, therefore goes out with "Content-Length" among lower-case headers, which changes how the request looks. Keep bogdanfinn#32's single header and computed values, but write them under the name the caller used. If the caller used more than one spelling, or none, the name is canonical, as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pagpeter
force-pushed
the
caller-request-headers
branch
from
October 26, 2026 10:11
fb04d8d to
1ee3526
Compare
pagpeter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since bogdanfinn#32 the HTTP/1 request writer sends a single Content-Length with the request's value; before, a caller's
content-lengthwent out next to a canonical duplicate. The remaining header always gets the canonical name, though, so a request whose headers are all lower case (as Node's fetch writes them) carriesContent-Lengthamong lower-case headers (see tls-client#101).This keeps bogdanfinn#32's single header and computed value, but writes Content-Length, Transfer-Encoding and Trailer under the name the caller used. If the caller used several spellings or none, the name is canonical, as on master. HTTP/2 lowercases names and is unaffected.
TestRequestWriteKeepsTransferHeaderNames(inrequestwrite_test.go) fails on master for lowercase and uppercase Content-Length,transfer-encodingandtrailer, and covers two spellings and a GET that drops a caller's Content-Length.go test ./...passes.🤖 Generated with Claude Code