Repository navigation
Build the release with uv instead of hatch - #39
Merged
Merged
Conversation
`create-release.yml` was the only workflow not going through `uv`: it set up a Python, `pip install hatch`, then `hatch clean && hatch build`. Every other job -- tests, docs, canary -- installs `astral-sh/setup-uv` and runs `uv`, and so does every developer. `uv build` drives the same `hatchling` backend `[build-system]` declares, so the sdist and wheel are the artifacts `uv build` already produces locally. It also resolves an interpreter matching `requires-python` on its own, so the `actions/setup-python` step goes with it. `hatch clean` goes too: the runner checks out fresh, so there is no stale `dist/` for the release upload to pick up. This is the same objection as the retired hatch envs and `docs/requirements.txt` -- a second way to reach the same thing is a second thing to keep in step. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create-release.ymlwas the only workflow not going throughuv. It set up a Python,pip install hatch, then ranhatch clean && hatch build, while tests, docs and canary all installastral-sh/setup-uvand runuv-- as does every developer, per CLAUDE.md.uv builddrives the samehatchlingbackend[build-system]declares, so the sdist and wheel are the artifactsuv buildalready produces locally. Two steps go with it:actions/setup-python, becauseuvresolves an interpreter matchingrequires-pythonon its own.hatch clean, because the runner checks out fresh -- there is no staledist/for the release upload to pick up.This is the same objection as the retired hatch envs and
docs/requirements.txt: a second way to reach the same thing is a second thing to keep in step.Not changed
The PyPI upload stays on Trusted Publishing. This came up as a question of whether the workflow matched
panoptes-utils, which still uses a long-livedPYPI_API_TOKEN-- matching it there would be a downgrade, and would contradict CLAUDE.md, which states that tagging publishes via Trusted Publishing and cuts the release from the annotated tag's message. The release-notes source, the annotated-tag guard and theid-token: writepermission are all untouched.panoptes-utilsis the one that should be brought forward; filing that separately.Verification
uv buildrun locally against this branch produces both artifacts, withhatch-vcsstill deriving the version from git (0.5.1.dev0+ge82975406), so tag-derived versioning is intact. The workflow YAML parses and thedeployjob's steps resolve in order.The publish path itself only executes on a
v*tag push, so it is not exercised until the next release.🤖 Generated with Claude Code