fix: suppress trivial_numeric_casts in derived Encode/Decode - #825
Merged
bkchr merged 1 commit intoSep 13, 2026
Merged
Conversation
Generated enum index casts are already usize/u8 in the common cases, so deny(trivial_numeric_casts) in downstream crates failed to compile a simple enum. Allow the lint next to the existing clippy cast allows. Fixes paritytech#740
Contributor
Author
bkchr
approved these changes
Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Encode/Decodefor enums emitted(index) as usize/as u8even when the index was already that type, so crates with#![deny(trivial_numeric_casts)]failed to compile a two-variant enum.trivial_numeric_castson the generated index checks and match arms, matching the existingclippy::unnecessary_castallows.tests/clippy.rsnowdenys that lint and includes a unit enum matching the report.Test plan
cargo +stable test --locked --test clippycargo +stable clippy --locked --test clippy -- -Dwarningsfmt/clippy/testsjobsFixes #740